-
Notifications
You must be signed in to change notification settings - Fork 343
fix(query): adding missing function_app resources to terraform/azure queries #7744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cx-andre-pereira
wants to merge
16
commits into
master
Choose a base branch
from
AST-114931-FN-Missing_resources_for_terraform_azure_queries_2_function_apps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(query): adding missing function_app resources to terraform/azure queries #7744
cx-andre-pereira
wants to merge
16
commits into
master
from
AST-114931-FN-Missing_resources_for_terraform_azure_queries_2_function_apps
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm_azure_queries_2_function_apps
…14931-FN-Missing_resources_for_terraform_azure_queries_2_function_apps
…ries_2_function_apps' of https://github.com/Checkmarx/kics into AST-114931-FN-Missing_resources_for_terraform_azure_queries_2_function_apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6927
Reason for Proposed Changes
(Queries 1-4 are handled in the "parent" Pull Request where this issue was first handled for some similar "azurerm_app_service" resource related queries)
Proposed Changes
types
array to include the relevant resource types. For details on the analog's implementation : PR7591 and PR7715. Simply put the older resource only has the "auth_settings" field to check while the newly supported ones have that same resource plus the new "auth_settings_v2", and both can be defined concurrently in which case the v2 takes precedence, so the logic for the query and the tests had to be more complex/comprehensive overall.I submit this contribution under the Apache-2.0 license.