Skip to content

[email protected]: Add manifest for MCreator app #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[email protected]: Add manifest for MCreator app #1405

wants to merge 5 commits into from
+30 −0

Conversation

m-saliola
Copy link

@m-saliola m-saliola commented May 24, 2025 •
edited
Loading

This pull request adds a Scoop manifest for MCreator version 2025.1

  • Downloads official release zip from GitHub
  • Includes SHA256 hash for verification
  • Adds the main executable for easy access
  • Provides shortcuts, checkver, and autoupdate support

Tested locally, installs and runs fine.

@aliesbelik aliesbelik mentioned this pull request May 24, 2025
Closed
6 tasks
@z-Fng
Copy link
Contributor

z-Fng commented May 25, 2025

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mcreator

  • Description
  • License
  • Hashes

@z-Fng
Copy link
Contributor

z-Fng commented May 25, 2025 •
edited
Loading

I think it would be beneficial to include more manifest details like shortcuts, checkver, and autoupdate for better functionality.

@github-actions GitHub Actions
Copy link
Contributor

Your changes do not pass checks.

mcreator

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Calinou Calinou added the new package A package should be added label May 26, 2025
Calinou
Calinou reviewed May 26, 2025
View reviewed changes
Calinou
Calinou approved these changes May 26, 2025
View reviewed changes
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Calinou
Calinou reviewed May 26, 2025
View reviewed changes
bucket/mcreator.json
Comment on lines +12 to +18
"bin": "MCreator20251/mcreator.exe",
"shortcuts": [
[
"MCreator20251/mcreator.exe",
"MCreator"
]
],
Copy link
Owner

@Calinou Calinou May 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "extract_dir": "MCreator20251" so that the top-level folder isn't present (we don't need it, and its name is version-specific).

extract_dir should also be specified in autoupdate using the $cleanVersion placeholder (which is like $version but with periods removed).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBrine85 You can check this wiki for more information about version variables:
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifest-Autoupdate#version-variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

+1 more reviewer

@z-Fng z-Fng z-Fng left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
manifest-fix-needed new package A package should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-saliola @z-Fng @Calinou