Skip to content

Make Rule.conditions readonly (fixes #419) #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make Rule.conditions readonly (fixes #419) #420

wants to merge 3 commits into from

Conversation

emilefokkemanavara
Copy link
Contributor

@emilefokkemanavara emilefokkemanavara commented May 29, 2025 •
edited
Loading

This

  • changes a test to use the correct setter method to change a Rule's conditions
  • adds a test that shows that Rule.conditions is not the right setter
  • marks Rule.conditions as readonly in the types

Fixes #419

@emilefokkemanavara emilefokkemanavara changed the title Make Rule.conditions readonly Make Rule.conditions readonly (fixes #419) May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jddejong2 jddejong2 jddejong2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typings incorrectly suggest that Rule.conditions is a setter

2 participants

@emilefokkemanavara @jddejong2