Upgrading to prompt_toolkit 2.0

[oldboldpilot]

Will it take a lot to upgrade this to work with prompt_toolkit 2.0?
Is there any help I can render to make that happen?

[CITGuru]

I am afraid to say that won't happen anytime soon. Cos upgrading to 2.0, will require a lot of work and rewiring. prompt_toolkit 2.0 was rewritten from scratch and they totally ditch Token and many other things PyInquirer depends on. What I could suggest is we create PyInquirer2 from scratch that will work with prompt_toolkit 2.0. And that will only happen once I am able to complete all TODO we still have left. I have thought of this sometime ago and that's the only solution. So people could choose the version they want.

[oldboldpilot]

That sounds fair, will be willing to work on PyInquirer2 then, it does not seem like a bad idea. Thanks for responding so quickly 👍

[CITGuru]

You welcome, I'll be glad to work with you in the nearest future 🤝

[rigogsilva]

Let's get this going. I'd be willing to help out. Mostly to get the autocomplete functionality.

[Apreche]

Just discovered PyInquirer, and it's not working for me because iPython uses prompt-toolkit 2, and that causes a conflict.

[CITGuru]

@rigogsilva Thanks for that, I'd be glad if we could work on it. @Apreche Yeah, you can't use PyInquirer on iPython cos, PyInquirer still uses Prompt toolkit 1.0

[CITGuru]

And talking about Pompt toolkit 2.0, I actually devoted my free time to read the doc and went through the source code. Though some huge changes are made but not as I expected, PyInquirer rely on Token which is from prompt toolkit Pygments for coloring alot. In 2.0 we can still use it in a better and creative. I actually like the way they structure the new style_from_dict. Off course there are some other changes I need to point out.

I have been busy lately cos my remote company is pushing out new products these past months and has not been easy for core Python and Rust developers.

So PyInquirer 1.0.3 will be released soon, I'll already draft the release, I just need time to fix some issues. You can check out https://github.com/CITGuru/PyInquirer/issues/ and look at the ones you can suggest fix for.

The dev branch commits has been merged into master. So you can now install from master.

PyInquirer 2 development will be pushed to github for contribution on the release date of PyInquirer 1.0.3.

Read about Prompt toolkit 2.0 - https://python-prompt-toolkit.readthedocs.io/

Thanks

[tmbo]

Yes, happy to help out as well - let’s get this going 🚀

[tmbo]

@CITGuru how willing are you to move quick on this? We depend on this library for one of our larger projects, but the usage of prompt_toolkit is a dealbreaker because of ipythons dependency on prompt_toolkit2.

As said, I am very happy to help out. I've been looking into it and it is actually rather straight forward. I don't understand why the development for this is waiting for a minor release (why not create a bugfix branch for 1.0.x) instead of going full steam on this.

I know this is a side project for you, therefore I completely understand if you let me know that you just do not have enough time to move this project forward.

My team needs to move fast on this, but since you have been putting so much work into maintaining this library, I also do not want to step on your tows. We'll have a prompt toolkit 2 ready version by the end of the week, the question is if it is going to be part of this project or a fork.

[CITGuru]

I really appreciate your concerns and understanding. I know how we feel when our projects depend on a good and promising project. But what turn us off is when the project is poorly maintained, I mean, that was the whole idea of PyInquirer. So I am looking at the best way to create time for managing this project.

While we wait for PyInquirer 2, I decided to release PyInquirer 1.0.3 bugfix release earlier as expected. @tmbo Its out now

[tmbo]

That's great news 🚀 and I'd be way happier keeping this project going then to create a fork.

I know it is challenging to balance open source, your job and your private life - so let's find ways to make this work.

You mentioned that you already started working on prompt toolkit 2 support, do you mind pushing that code so that we can properly branch of from there? If not thats fine as well, and I'll just create a PR against master.

[CITGuru]

@tmbo I'll be working on it this weekend so I should be able to push up what I have by monday, if all goes as scheduled

[tmbo]

I did convert the list and confirm views locally, so let me know if you need them.