Skip to content

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Sep 26, 2025

Fixes bug with submeshes where indexStart was improperly handled when creating the buffer view.
While in the area, I did some contained refactoring. The main points are:

  • No more offset parameter. I think this was a remnant from before the rework last year, as I couldn't tell what it would've been used for.
  • As little copying as possible, which also means subsetting ahead of time.
  • Miscellaneous clean up

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants