Skip to content

Conversation

amnguye
Copy link
Member

@amnguye amnguye commented Oct 2, 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@amnguye amnguye requested a review from seanmcc-msft as a code owner October 2, 2025 18:24
@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 18:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes test failures related to changes in the Azure Storage SDK's GetBlobs method API. The changes update test code to use the new GetBlobsOptions parameter structure instead of the deprecated direct prefix parameter.

  • Updates GetBlobs method call to use GetBlobsOptions object with Prefix property
  • Adds necessary using statement for Azure.Storage.Blobs.Models namespace

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Oct 2, 2025
@amnguye
Copy link
Member Author

amnguye commented Oct 2, 2025

/azp run net - storage - functions

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amnguye
Copy link
Member Author

amnguye commented Oct 2, 2025

@fabiocav @mathewc These changes are tests only. There are no changes to the source code of webjobs storage extension. Feel free to review anyways, but may be unnecessary.

@amnguye
Copy link
Member Author

amnguye commented Oct 2, 2025

@fabiocav @mathewc These changes are tests only. There are no changes to the source code of webjobs storage extension. Feel free to review anyways, but may be unnecessary.

I take this back, I had to make changes to the source code, but they're not functional/behavioral changes. They're just adjustments to the GetBlobs API call.

@amnguye
Copy link
Member Author

amnguye commented Oct 2, 2025

/azp run net - storage - functions

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member

@amnguye can this be merged?

@amnguye
Copy link
Member Author

amnguye commented Oct 3, 2025

@amnguye can this be merged?

I'm waiting on @mathewc or @fabiocav . We need to have at least one approval from our side and one approval from the webjobs folks in order to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants