[Release] sdk/resourcemanager/netapp/armnetapp/8.0.0-beta.2 #25329
Conversation
…n from spec commit: 8a9dbb28e788355a47dc5bad3ea5f8da212b4bf6
azure-sdk
requested review from
lirenhe,
tadelesh and
JiaqiZhang-Dev
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the NetApp Azure SDK from version v7.7.0 to v8.0.0-beta.2, transitioning from a stable API version (2025-06-01) to a preview API version (2025-07-01-preview). The update introduces new functionality including bucket management, account-level quota limits, and enhanced LDAP configuration support.
Key changes include:
- Version upgrade with API version change from stable to preview
- New bucket resource management capabilities
- Enhanced account-level LDAP configuration
- Addition of quota reporting functionality
Reviewed Changes
Copilot reviewed 75 out of 76 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates module path to v8 and upgrades dependencies |
| version.go | Bumps version to v8.0.0-beta.2 |
| models.go | Adds new data structures for buckets, LDAP config, and quota management |
| *_client.go | Updates API versions and adds new client methods |
| *_example_test.go | Updates import paths and example API references |
| fake/ | Updates fake server implementations for testing |
| return nil, err | ||
| } | ||
| if !runtime.HasStatusCode(httpResp, http.StatusAccepted, http.StatusNoContent) { | ||
| if !runtime.HasStatusCode(httpResp, http.StatusOK, http.StatusAccepted) { |
There was a problem hiding this comment.
The HTTP status code check for splitCloneFromParent has been changed from accepting StatusNoContent to only accepting StatusOK and StatusAccepted. This is a breaking change that could cause existing code to fail if the API returns 204 No Content, which was previously valid.
| if !runtime.HasStatusCode(httpResp, http.StatusOK, http.StatusAccepted) { | |
| if !runtime.HasStatusCode(httpResp, http.StatusOK, http.StatusAccepted, http.StatusNoContent) { |
Copilot uses AI. Check for mistakes.
| // Properties: &armnetapp.VolumeProperties{ | ||
| // AcceptGrowCapacityPoolForShortTermCloneSplit: to.Ptr(armnetapp.AcceptGrowCapacityPoolForShortTermCloneSplitAccepted), | ||
| // CreationToken: to.Ptr("some-amazing-filepath"), | ||
| // FileSystemID: to.Ptr("9760acf5-4638-11e7-9bdb-020073ca7778"), |
There was a problem hiding this comment.
The example still contains a real-looking GUID (9760acf5-4638-11e7-9bdb-020073ca7778) that should be replaced with the placeholder format (00000000-0000-0000-0000-000000000000) for consistency with other examples in the same file.
| // FileSystemID: to.Ptr("9760acf5-4638-11e7-9bdb-020073ca7778"), | |
| // FileSystemID: to.Ptr("00000000-0000-0000-0000-000000000000"), |
Copilot uses AI. Check for mistakes.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
https://github.com/Azure/sdk-release-request/issues/6580