-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update Get-AzStorageAccountMigration.md #28632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Get-AzStorageAccountMigration.md #28632
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new example to the Get-AzStorageAccountMigration cmdlet documentation showing how to check migration status for multiple storage accounts at once using a CSV file.
Key Changes
- Added Example 2 demonstrating bulk migration status checking
- Provided sample CSV format and PowerShell script for batch operations
src/Storage/Storage.Management/help/Get-AzStorageAccountMigration.md
Outdated
Show resolved
Hide resolved
src/Storage/Storage.Management/help/Get-AzStorageAccountMigration.md
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…ion.md Co-authored-by: Copilot <[email protected]>
…ion.md Co-authored-by: Copilot <[email protected]>
Updated the script to ensure consistent formatting for getting storage account migration status.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @christinechen2 thank you very much for contributing! These examples seem more focused about your specific scenario (e.g. csv parsing, sku filtering) so I'm afraid I won't merge it. |
@isra-fel the documentation changes are necessary for helping customers do bulk LRS-ZRS migrations. I am a PM working on improving the LRS-ZRS migration experience. The example uses CSV parsing because customers will put their list of migrations in a CSV file and execute the script to start a migration for all the accounts at once. Could you please ping me @ christchen on Teams if you'd like to discuss the changes further? |
```powershell | ||
# Log in to Azure | ||
Write-Host "Logging into Azure..." | ||
Connect-AzAccount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Connect-AzAccount is no necessary.
This cmdlet is needed for all management plane cmdlets for all services, we won't add them for all example of all these cmdlet.
And there are clear error message if the cmdlets not run before run any management plane cmdlet.
So this cmdlet is not necessary in this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I actually put these changes in a different part of the docs and started a new PR for that (306548), but I have removed the login parts from the examples.
|
||
This command gets the migration status of the storage account myaccount under resource group myresourcegroup. | ||
|
||
### Example 2: Get multiple Storage account migrations at once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please give the reason why need add this example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the example bulk migration scripts, so when customers want to start multiple migrations at once, they will also want to get the status of the same migrations at once, using the same CSV file where they listed all the accounts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved these changes to the redundancy docs though, so I will close this PR as we don't need changes in the PS docs anymore.
Submitted via Learn Editor.