-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[PS] RedisEnterpriseCache add breaking change for migration autorest v4 #28621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -271,4 +271,18 @@ directive: | |||||||||||||||||||||||||||||
- from: source-file-csharp | ||||||||||||||||||||||||||||||
where: $ | ||||||||||||||||||||||||||||||
transform: $ = $.replace(/Module.Instance.SetProxyConfiguration\(/g, 'Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Module.Instance.SetProxyConfiguration('); | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
# Breaking change | ||||||||||||||||||||||||||||||
- where: | ||||||||||||||||||||||||||||||
verb: Get | ||||||||||||||||||||||||||||||
subject: OperationStatus | ||||||||||||||||||||||||||||||
set: | ||||||||||||||||||||||||||||||
preview-announcement: | ||||||||||||||||||||||||||||||
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************" | ||||||||||||||||||||||||||||||
- where: | ||||||||||||||||||||||||||||||
verb: Update | ||||||||||||||||||||||||||||||
subject: ^$ | ||||||||||||||||||||||||||||||
set: | ||||||||||||||||||||||||||||||
preview-announcement: | ||||||||||||||||||||||||||||||
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************" | ||||||||||||||||||||||||||||||
Comment on lines
+281
to
+287
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The preview message is duplicated in the AutoRest configuration. Consider using YAML anchors (&anchor and *alias) to define the message once and reference it in multiple places to reduce duplication.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||||||||||||||||||||||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,11 @@ MODULE <IModule[]>: Optional set of redis modules to enable in this database - m | |
https://learn.microsoft.com/powershell/module/az.redisenterprisecache/update-azredisenterprisecachedatabase | ||
#> | ||
function Update-AzRedisEnterpriseCacheDatabase { | ||
[Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Runtime.PreviewMessage("**********************************************************************************************`n | ||
* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *`n | ||
* At least one change applies to this cmdlet. *`n | ||
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n | ||
***************************************************************************************************")] | ||
Comment on lines
+62
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The breaking change message is duplicated across multiple cmdlets. Consider defining this as a constant to improve maintainability and ensure consistency across all cmdlets. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
[OutputType([Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20250501Preview.IDatabase])] | ||
[CmdletBinding(DefaultParameterSetName='UpdateExpanded', PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')] | ||
param( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"generate_Id": "88eb441e-51a0-4712-82e3-224b9a92b315" | ||
"generate_Id": "f22ea3fa-fa21-4917-872c-78974cd6a34f" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview message is duplicated in the AutoRest configuration. Consider using YAML anchors (&anchor and *alias) to define the message once and reference it in multiple places to reduce duplication.
Copilot uses AI. Check for mistakes.