[Az.DataProtection] ADLS backup + rename restore container #28608
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Azure Data Protection module to support Azure Data Lake Storage (ADLS) backup functionality and adds container renaming capabilities for alternate location item-level recovery. The changes also upgrade the API version from 2025-01-01 to 2025-07-01 throughout the module.
Key changes:
- Adds ADLS Gen2 support as a new datasource type alongside existing blob storage backup
- Introduces container renaming functionality (
RenameToparameter) for alternate location restores - Updates API version references throughout the codebase and documentation
Reviewed Changes
Copilot reviewed 121 out of 121 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Az.DataProtection.psd1 | Updates module dependencies and generated metadata |
| DataProtection.sln | Updates project GUID reference |
| Enums.cs | Adds AzureDataLakeStorage to supported datasource types |
| Various help files | Updates API version references and adds ADLS support documentation |
| Test files | Adds comprehensive ADLS backup/restore tests and container renaming validation |
| Manifest files | Adds ADLS configuration and enables container renaming for blob storage |
| Custom cmdlets | Updates type references and adds ADLS support throughout |
| $vault = Get-AzDataProtectionBackupVault -SubscriptionId $subId -ResourceGroupName $resourceGroupName -VaultName $vaultName | ||
|
|
||
| $instance = Get-AzDataProtectionBackupInstance -SubscriptionId $subId -ResourceGroupName $resourceGroupName -VaultName $vaultName | Where-Object { $_.Name -match $storageAcountName } | ||
| $instance = Get-AzDataProtectionBackupInstance -SubscriptionId $subId -ResourceGroupName $resourceGroupName -VaultName $vaultName | Where-Object { $_.Name -match $storageAccountName } |
There was a problem hiding this comment.
Variable name $storageAcountName is misspelled as $storageAccountName in the corrected line, but the original variable was consistently misspelled. This creates an inconsistency where the variable is defined as $storageAcountName but referenced as $storageAccountName.
Copilot uses AI. Check for mistakes.
| ### -IdentityType | ||
| This parameter is no longer in use and will be depricated | ||
| This parameter is no longer in use and will be deprecated |
There was a problem hiding this comment.
Fixed spelling from 'depricated' to 'deprecated'.
Copilot uses AI. Check for mistakes.
| ### -IdentityType | ||
| This parameter is no longer in use and will be depricated | ||
| This parameter is no longer in use and will be deprecated |
There was a problem hiding this comment.
Fixed spelling from 'depricated' to 'deprecated'.
Copilot uses AI. Check for mistakes.
| ### -IntervalType | ||
| Freuquency of the backup. | ||
| Frequency of the backup. |
There was a problem hiding this comment.
Fixed spelling from 'Freuquency' to 'Frequency'.
Copilot uses AI. Check for mistakes.
|
|
||
| ### -BackupInstance | ||
| Backup Instance object to trigger original localtion restore. | ||
| Backup Instance object to trigger original location restore. |
There was a problem hiding this comment.
Fixed spelling from 'original localtion' to 'original location'.
Copilot uses AI. Check for mistakes.
| ### -PolicyId | ||
| Policy Id to be assiciated to Datasource | ||
| Policy Id to be associated to Datasource |
There was a problem hiding this comment.
Fixed spelling from 'assiciated' to 'associated' and 'Sanpshot' to 'Snapshot'.
Copilot uses AI. Check for mistakes.
| ### -SnapshotResourceGroupId | ||
| Sanpshot Resource Group | ||
| Snapshot Resource Group |
There was a problem hiding this comment.
Fixed spelling from 'assiciated' to 'associated' and 'Sanpshot' to 'Snapshot'.
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
-
new and updated test cases need to be recorded.
-
tests need to be re-recorded due to api upgrade
-
please update https://github.com/MabOneSdk/azure-powershell/blob/users/ianna/adlsbackup/src/DataProtection/DataProtection/ChangeLog.md
-
please review comments from copilot
-
there are compilation issues due to api upgrade
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.