Skip to content

Conversation

bvandercar-vt
Copy link
Contributor

Fix current a11y failures by changing role structure to tree/treeitems. Change keypress actions to match what should occur on a tree using this example: https://www.w3.org/WAI/ARIA/apg/patterns/treeview/examples/treeview-1a/

  • Update tests
  • Manually tested

@AnyRoad
Copy link
Owner

AnyRoad commented Sep 14, 2024

Hi! Thank you for the PR, I'm not so much familiar with a11y but definitely would like to follow the standards.
The only one concern for the PR is performance. Parts like getting button elements with querySelectorAll and setTabbableButton can significantly slow down rendering process.

I've tried component with 300kb JSON and doesn't feel much slower.

Even though I consider such changes to be part of the major version upgrade along with the #20 React 16/17 deprecation.

@bvandercar-vt
Copy link
Contributor Author

bvandercar-vt commented Sep 16, 2024

@AnyRoad I don't think you'd ever notice a loss in performance at a human level.

However I did make some changes that would theoretically improve performance slightly: 4856580 , 37c81f8

@AnyRoad AnyRoad mentioned this pull request Sep 24, 2024
@AnyRoad AnyRoad merged commit 2ca3f91 into AnyRoad:release Sep 29, 2024
@bvandercar-vt bvandercar-vt deleted the bvandercar/change-role-structure-to-tree branch November 7, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants