Skip to content

feat: move CUDA prebuilt binaries to dependency modules #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 29, 2024
Merged

feat: move CUDA prebuilt binaries to dependency modules #250

merged 11 commits into from
Jun 29, 2024

Conversation

giladgd
Copy link
Member

@giladgd giladgd commented Jun 26, 2024 •
edited
Loading

Description of change

  • feat: move CUDA prebuilt binaries to dependency modules to improve npm install times
  • fix: improve GGUF metadata reading performance
  • fix: adapt to breaking llama.cpp changes

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto June 26, 2024 23:00
@giladgd giladgd self-assigned this Jun 26, 2024
@giladgd giladgd changed the title fix: improve the performance of reading GGUF metadata fix: improve GGUF metadata reading performance Jun 26, 2024
ido-pluto
ido-pluto approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd changed the title fix: improve GGUF metadata reading performance feat: move CUDA prebuilt binaries to dependency modules Jun 28, 2024
@giladgd giladgd merged commit 8a92e31 into beta Jun 29, 2024
@giladgd giladgd deleted the gilad/adaptToBreakingChanges branch June 29, 2024 21:00
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.0-beta.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited by giladgd
Loading

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladgd @ido-pluto