Skip to content

Commit e46fc2f

Browse files
committed
Only run "perform a security check" for Window and Location objects
These days all implementations only have security checks on a couple of objects. Firefox used to have cross-origin object wrapper, but those are no longer web observable. Tests: html/browsers/origin/cross-origin-objects/cross-origin-objects.html and web-platform-tests/wpt#20432.
1 parent 928f862 commit e46fc2f

File tree

1 file changed

+13
-17
lines changed

1 file changed

+13
-17
lines changed

source

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -79545,31 +79545,27 @@ console.assert(iframeWindow.frameElement === null);
7954579545
<var>identifier</var>, and <var>type</var>, run these steps:</p>
7954679546

7954779547
<ol>
79548+
<li><p>If <var>platformObject</var> is not a <code>Window</code> or <code>Location</code> object,
79549+
then return.</p>
79550+
7954879551
<li>
79549-
<p>If <var>platformObject</var> is a <code>Window</code> or <code>Location</code> object,
79550-
then:</p>
79552+
<p>Repeat for each <var>e</var> that is an element of !
79553+
<span>CrossOriginProperties</span>(<var>platformObject</var>):</p>
7955179554

7955279555
<ol>
7955379556
<li>
79554-
<p>Repeat for each <var>e</var> that is an element of !
79555-
<span>CrossOriginProperties</span>(<var>platformObject</var>):</p>
79557+
<p>If <span>SameValue</span>(<var>e</var>.[[Property]], <var>identifier</var>) is true,
79558+
then:</p>
7955679559

7955779560
<ol>
79558-
<li>
79559-
<p>If <span>SameValue</span>(<var>e</var>.[[Property]], <var>identifier</var>) is true,
79560-
then:</p>
79561+
<li><p>If <var>type</var> is "<code data-x="">method</code>" and <var>e</var> has neither
79562+
[[NeedsGet]] nor [[NeedsSet]], then return.</p></li>
7956179563

79562-
<ol>
79563-
<li><p>If <var>type</var> is "<code data-x="">method</code>" and <var>e</var> has neither
79564-
[[NeedsGet]] nor [[NeedsSet]], then return.</p></li>
79565-
79566-
<li><p>Otherwise, if <var>type</var> is "<code data-x="">getter</code>" and
79567-
<var>e</var>.[[NeedsGet]] is true, then return.</p></li>
79564+
<li><p>Otherwise, if <var>type</var> is "<code data-x="">getter</code>" and
79565+
<var>e</var>.[[NeedsGet]] is true, then return.</p></li>
7956879566

79569-
<li><p>Otherwise, if <var>type</var> is "<code data-x="">setter</code>" and
79570-
<var>e</var>.[[NeedsSet]] is true, then return.</p></li>
79571-
</ol>
79572-
</li>
79567+
<li><p>Otherwise, if <var>type</var> is "<code data-x="">setter</code>" and
79568+
<var>e</var>.[[NeedsSet]] is true, then return.</p></li>
7957379569
</ol>
7957479570
</li>
7957579571
</ol>

0 commit comments

Comments
 (0)