Skip to content

Migrate away from componentWillReceiveProps #1084

@havardh

Description

@havardh

Hi. 👋

By running in react strict-mode, I noticed that that react-vis relies on the now deprecated componentWillReciveProps.

With a quick search in the repo I found the following usages (examples are omitted):

These should be easily resolvable by moving to either getDerivedStateFromProps or componentDidUpdate or memoization as detailed here and here.

Are there any plans for doing or concerns about doing these changes?

If these changes makes sense for the project, I could make a PR for them 👍

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions