Skip to content

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Jan 8, 2021

TL;DR: lodash.merge does not merge arrays, so plugins and vuex/router were overriding each other and other plugins.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #200 (80d574c) into next (ca5f32c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              next      #200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           84        84           
  Branches        29        30    +1     
=========================================
  Hits            84        84           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca5f32c...80d574c. Read the comment docs.

Base automatically changed from fix-rerender to next January 8, 2021 14:28
@afontcu afontcu force-pushed the fix-several-plugins branch from c9725cb to 80d574c Compare January 8, 2021 14:46
@afontcu afontcu marked this pull request as ready for review January 8, 2021 14:47
@afontcu afontcu merged commit 92c3140 into next Jan 8, 2021
@afontcu afontcu deleted the fix-several-plugins branch January 8, 2021 14:51
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant