fix(on_message): adjust advisor

- Attempt a DM first, if that fails then do an inline reply with the converted x.com link

Author: theetrain

src/events/on_message/_advise.ts

@@ -23,6 +23,7 @@ export default async function mutate_content(message: Message) {
 				) !== -1,
 		);
 	if (!caughtLinks) return;
+
 	const hasXLinks: boolean = caughtLinks.some((item) =>
 		item.startsWith('https://x.com'),
 	);
@@ -32,17 +33,18 @@ export default async function mutate_content(message: Message) {
 		caughtLinks.length > 1
 			? 'Here are the updated links:'
 			: 'Here is the updated link:';
-	const updatedLinks = caughtLinks
-		.map((link) => {
-			const replaceIdx = replacementMap.findIndex((item) =>
-				link.startsWith(item.test),
-			);
-			return link.replace(
-				replacementMap[replaceIdx].test,
-				replacementMap[replaceIdx].replace,
-			);
-		})
-		.join('\n');
+
+	const updatedLinks = caughtLinks.map((link) => {
+		const replaceIdx = replacementMap.findIndex((item) =>
+			link.startsWith(item.test),
+		);
+		return link.replace(
+			replacementMap[replaceIdx].test,
+			replacementMap[replaceIdx].replace,
+		);
+	});
+
+	const updatedLinkList = updatedLinks.map((link) => `- ${link}\n`).join('');
 
 	const updatedMessage: string = (function () {
 		let newContent = message.content;
@@ -53,7 +55,22 @@ export default async function mutate_content(message: Message) {
 		return newContent;
 	})();
 
-	await message.author.send(
-		`Re: ${message.url}\n\nI see you've provided a link to \`x.com\`. Please consider posting a new message having \`x.com\` replaced with \`xcancel.com\`, that way server members may view the message and thread without requiring an account.\n\n${updatedPhrase}\`\`\`${updatedLinks}\`\`\`\n\nHere is your entire message with adjusted links:\n\`\`\`${updatedMessage}\`\`\``,
-	);
+	try {
+		await message.author.send(
+			`Re: ${message.url}\n\nI see you've provided a link to \`x.com\`. Please consider posting a new message having \`x.com\` replaced with \`xcancel.com\`, that way server members may view the message and thread without requiring an account.\n\n${updatedPhrase}\`\`\`${updatedLinkList}\`\`\`\n\nHere is your entire message with adjusted links:\n\`\`\`${updatedLinkList}\`\`\``,
+		);
+
+		return; // mission complete
+	} catch (e) {
+		// assume user disabled DMs upon error
+	}
+
+	// Plan B: inline reply
+	try {
+		await message.reply(
+			`I converted your \`x.com\` links to use \`xcancel.com\` so that server members won't require an account to view content and threads.\n\n${updatedLinkList}`,
+		);
+	} catch (e) {
+		// don't handle failures
+	}
 }