Validation fails on hidden rows in matrix when specifying eachRowRequired fix #10395 (#10398)

Author: andrewtelnov

packages/survey-core/src/question_matrix.ts

@@ -727,9 +727,6 @@ export class QuestionMatrixModel
     return !rowsErrors.noValue;
   }
   private checkErrorsAllRows(modifyErrors: boolean, res: { noValue: boolean, isNotUnique: boolean }, allRowsRequired?: boolean): void {
-    var rows = this.generatedVisibleRows;
-    if (!rows) rows = this.visibleRows;
-    if (!rows) return;
     const rowsRequired = this.eachRowRequired || allRowsRequired;
     const rowsUnique = this.eachRowUnique;
     res.noValue = false;
@@ -738,6 +735,8 @@ export class QuestionMatrixModel
       this.errorsInRow = undefined;
     }
     if (!rowsRequired && !rowsUnique) return;
+    const rows = this.visibleRows;
+    if (!rows) return;
     const hash: HashTable<any> = {};
     for (var i = 0; i < rows.length; i++) {
       const val = rows[i].value;

packages/survey-core/tests/question_matrix_tests.ts

@@ -476,6 +476,57 @@ QUnit.test("matrix eachRowRequired  & getItemClass", function (assert) {
   assert.equal(question.getItemClass(row, column1).indexOf(itemError) > -1, false, "itemError doesn't exist in column 1, #1");
   assert.equal(question.getItemClass(row, column2).indexOf(itemError) > -1, false, "itemError doesn't exist in column 2, #1");
 });
+QUnit.test("matrix eachRowRequired  & row visibleIf, Bug#10395.1", function (assert) {
+  const survey = new SurveyModel({
+    elements: [
+      {
+        type: "matrix",
+        name: "q1",
+        columns: ["col1"],
+        rows: ["row1", { value: "row2", visibleIf: "false" }],
+        eachRowRequired: true
+      },
+    ]
+  });
+  const question = <QuestionMatrixModel>survey.getQuestionByName("q1");
+  assert.equal(question.visibleRows.length, 1, "There is one visible row");
+  question.visibleRows[0].value = "col1";
+  assert.equal(question.validate(), true, "There is no errors");
+});
+QUnit.test("matrix eachRowRequired  & row visibleIf, Bug#10395.2", function (assert) {
+  const survey = new SurveyModel({
+    elements: [
+      {
+        type: "matrixdropdown",
+        name: "q1",
+        columns: [{ name: "col1", cellType: "text" }],
+        rows: ["row1", { value: "row2", visibleIf: "false" }],
+        eachRowRequired: true
+      },
+    ]
+  });
+  const question = <QuestionMatrixModel>survey.getQuestionByName("q1");
+  assert.equal(question.visibleRows.length, 1, "There is one visible row");
+  question.visibleRows[0].value = "col1";
+  assert.equal(question.validate(), true, "There is no errors");
+});
+QUnit.test("matrix eachRowRequired  & row visibleIf, Bug#10395.2", function (assert) {
+  const survey = new SurveyModel({
+    elements: [
+      {
+        type: "matrixdropdown",
+        name: "q1",
+        columns: [{ name: "col1", cellType: "text", isUnique: true }],
+        rows: ["row1", { value: "row2", visibleIf: "false" }],
+        eachRowRequired: true
+      },
+    ]
+  });
+  const question = <QuestionMatrixModel>survey.getQuestionByName("q1");
+  question.value = { row1: "val1", row2: "val1" };
+  assert.equal(question.visibleRows.length, 1, "There is one visible row");
+  assert.equal(question.validate(), true, "There is no errors");
+});
 QUnit.test("hideIfRowsEmpty & question visibleIf, bug#8459", function (assert) {
   const survey = new SurveyModel({
     elements: [{ type: "matrix", name: "q1", visibleIf: "{a}=1", hideIfRowsEmpty: true, rows: [{ value: "row1", visibleIf: "{b}=2" }] }],