Skip to content

Commit e70a66f

Browse files
Yuval-Arieludi-speedb
authored andcommitted
db_bench: fix SeekRandomWriteRandom valid check (#652)
Use key and value only after checking iterator is valid
1 parent c6adb14 commit e70a66f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

HISTORY.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
### Enhancements
88

99
### Bug Fixes
10+
db_bench: fix SeekRandomWriteRandom valid check. Use key and value only after checking iterator is valid.
1011

1112
### Miscellaneous
1213

tools/db_bench_tool.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8149,13 +8149,14 @@ class Benchmark {
81498149
}
81508150

81518151
for (int j = 0; j < FLAGS_seek_nexts && iter_to_use->Valid(); ++j) {
8152+
bytes += iter_to_use->key().size() + iter_to_use->value().size();
8153+
81528154
if (!FLAGS_reverse_iterator) {
81538155
iter_to_use->Next();
81548156
} else {
81558157
iter_to_use->Prev();
81568158
}
81578159
assert(iter_to_use->status().ok());
8158-
bytes += iter_to_use->key().size() + iter_to_use->value().size();
81598160
}
81608161

81618162
if (seeks % 256 == 255) {

0 commit comments

Comments
 (0)