Merge pull request #42 from ccoveille-forks/slog-support

Support log/slog package

Author: sonatard

noctx.go

@@ -69,6 +69,16 @@ var ngFuncMessages = map[string]string{
 	"crypto/tls.Dial":              "must not be called. use (*crypto/tls.Dialer).DialContext",
 	"crypto/tls.DialWithDialer":    "must not be called. use (*crypto/tls.Dialer).DialContext with NetDialer",
 	"(*crypto/tls.Conn).Handshake": "must not be called. use (*crypto/tls.Conn).HandshakeContext",
+
+	// slog
+	"log/slog.Debug":           "must not be called. use log/slog.DebugContext",
+	"log/slog.Warn":            "must not be called. use log/slog.WarnContext",
+	"log/slog.Error":           "must not be called. use log/slog.ErrorContext",
+	"log/slog.Info":            "must not be called. use log/slog.InfoContext",
+	"(*log/slog.Logger).Debug": "must not be called. use (*log/slog.Logger).DebugContext",
+	"(*log/slog.Logger).Warn":  "must not be called. use (*log/slog.Logger).WarnContext",
+	"(*log/slog.Logger).Error": "must not be called. use (*log/slog.Logger).ErrorContext",
+	"(*log/slog.Logger).Info":  "must not be called. use (*log/slog.Logger).InfoContext",
 }
 
 func Run(pass *analysis.Pass) (interface{}, error) {

noctx_test.go

@@ -15,6 +15,7 @@ func TestAnalyzer(t *testing.T) {
 		{desc: "http_client"},
 		{desc: "http_request"},
 		{desc: "network"},
+		{desc: "slog"},
 		{desc: "sql"},
 	}
 

testdata/src/slog/slog.go

@@ -0,0 +1,43 @@
+package log
+
+import (
+	"context"
+	"log/slog"
+)
+
+func _() {
+	ctx := context.Background()
+
+	// default logger
+	slog.Debug("debug message", slog.String("key", "value")) // want `log/slog.Debug must not be called. use log/slog.DebugContext`
+	slog.Warn("warn message", slog.String("key", "value"))   // want `log/slog.Warn must not be called. use log/slog.WarnContext`
+	slog.Error("error message", slog.String("key", "value")) // want `log/slog.Error must not be called. use log/slog.ErrorContext`
+	slog.Info("info message", slog.String("key", "value"))   // want `log/slog.Info must not be called. use log/slog.InfoContext`
+
+	slog.DebugContext(ctx, "debug message", slog.String("key", "value"))
+	slog.WarnContext(ctx, "warn message", slog.String("key", "value"))
+	slog.ErrorContext(ctx, "error message", slog.String("key", "value"))
+	slog.InfoContext(ctx, "info message", slog.String("key", "value"))
+
+	slog.Default().Debug("debug message", slog.String("key", "value")) // want `\(\*log/slog.Logger\).Debug must not be called. use \(\*log/slog.Logger\).DebugContext`
+	slog.Default().Warn("warn message", slog.String("key", "value"))   // want `\(\*log/slog.Logger\).Warn must not be called. use \(\*log/slog.Logger\).WarnContext`
+	slog.Default().Error("error message", slog.String("key", "value")) // want `\(\*log/slog.Logger\).Error must not be called. use \(\*log/slog.Logger\).ErrorContext`
+	slog.Default().Info("info message", slog.String("key", "value"))   // want `\(\*log/slog.Logger\).Info must not be called. use \(\*log/slog.Logger\).InfoContext`
+
+	slog.Default().DebugContext(ctx, "debug message", slog.String("key", "value"))
+	slog.Default().WarnContext(ctx, "warn message", slog.String("key", "value"))
+	slog.Default().ErrorContext(ctx, "error message", slog.String("key", "value"))
+	slog.Default().InfoContext(ctx, "info message", slog.String("key", "value"))
+
+	// Logger struct
+	l := slog.New(slog.NewTextHandler(nil, nil))
+	l.Debug("debug message", slog.String("key", "value")) // want `\(\*log/slog.Logger\).Debug must not be called. use \(\*log/slog.Logger\).DebugContext`
+	l.Warn("warn message", slog.String("key", "value"))   // want `\(\*log/slog.Logger\).Warn must not be called. use \(\*log/slog.Logger\).WarnContext`
+	l.Error("error message", slog.String("key", "value")) // want `\(\*log/slog.Logger\).Error must not be called. use \(\*log/slog.Logger\).ErrorContext`
+	l.Info("info message", slog.String("key", "value"))   // want `\(\*log/slog.Logger\).Info must not be called. use \(\*log/slog.Logger\).InfoContext`
+
+	l.DebugContext(ctx, "debug message", slog.String("key", "value"))
+	l.WarnContext(ctx, "warn message", slog.String("key", "value"))
+	l.ErrorContext(ctx, "error message", slog.String("key", "value"))
+	l.InfoContext(ctx, "info message", slog.String("key", "value"))
+}