Skip to content

Commit 461c9e0

Browse files
author
Sean Alunni
committed
Fixed the bug that made "esbuild" emit React code if the user didn't provide UserConfig.esbuild
1 parent fede2c0 commit 461c9e0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,9 @@ export default function solidPlugin(options: Partial<Options> = {}): Plugin {
196196
userConfig.resolve.alias = normalizeAliases(userConfig.resolve && userConfig.resolve.alias);
197197

198198
// Forces "esbuild" to preserve JSX so that we can handle it here
199-
// If "esbuild" is not being used I don't need to change anything
200-
if (userConfig.esbuild) userConfig.esbuild.jsx ??= 'preserve';
199+
// If "esbuild" is not being used, we don't need to change anything
200+
if (userConfig.esbuild !== false)
201+
userConfig.esbuild = { jsx: 'preserve', ...userConfig.esbuild };
201202

202203
const solidPkgsConfig = await crawlFrameworkPkgs({
203204
viteUserConfig: userConfig,

0 commit comments

Comments
 (0)