Skip to content

Commit 36e2286

Browse files
committed
fix(deps): update dependency luxon to v3.3.0 & add @types/luxon (kelektiv#689)
## Description - added `@types/luxon` to dependencies - updated Luxon from `v3.2.1` to `v3.3.0` (avoided `v3.4.0` since types aren't available for that version yet). ## Related Issue Fixes kelektiv#688. ## Motivation and Context This library needs to depend on `@types/luxon` since we now export our own types. See the related issue for the error this fixes. ## How Has This Been Tested? - checked that TypeScript now correctly loads the Luxon types - ran tests locally ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
1 parent 98cc539 commit 36e2286

File tree

2 files changed

+20
-5
lines changed

2 files changed

+20
-5
lines changed

package-lock.json

Lines changed: 18 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@
2020
},
2121
"types": "types/index.d.ts",
2222
"dependencies": {
23-
"luxon": "^3.2.1"
23+
"@types/luxon": "~3.3.0",
24+
"luxon": "~3.3.0"
2425
},
2526
"devDependencies": {
2627
"@commitlint/cli": "~17.6.6",

0 commit comments

Comments
 (0)