From ea07201221398ba9052d596dac37e92591f3da79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Ber=C3=A1nek?= Date: Sat, 23 Aug 2025 10:12:51 +0200 Subject: [PATCH] Do not warn about missing change ID in tarball builds --- src/bootstrap/src/bin/main.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bootstrap/src/bin/main.rs b/src/bootstrap/src/bin/main.rs index 93c7faf4f0159..79369dd9cea8b 100644 --- a/src/bootstrap/src/bin/main.rs +++ b/src/bootstrap/src/bin/main.rs @@ -198,7 +198,8 @@ fn check_version(config: &Config) -> Option { Some(ChangeId::Id(id)) if id == latest_change_id => return None, Some(ChangeId::Ignore) => return None, Some(ChangeId::Id(id)) => id, - None => { + // The warning is only useful for development, not release tarballs + None if !config.rust_info.is_from_tarball() => { msg.push_str("WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations.\n"); msg.push_str("NOTE: to silence this warning, "); msg.push_str(&format!( @@ -206,6 +207,7 @@ fn check_version(config: &Config) -> Option { )); return Some(msg); } + None => return None, }; // Always try to use `change-id` from .last-warned-change-id first. If it doesn't exist,