Skip to content

Commit 22bbb4e

Browse files
committed
use let-else to reduce nesting
..and create a nice linear structure
1 parent 066bdb2 commit 22bbb4e

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

clippy_utils/src/msrvs.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -198,16 +198,16 @@ fn parse_attrs(sess: &Session, attrs: &[impl AttributeExt]) -> Option<RustcVersi
198198
.emit();
199199
}
200200

201-
if let Some(msrv) = msrv_attr.value_str() {
202-
if let Some(version) = parse_version(msrv) {
203-
return Some(version);
204-
}
201+
let Some(msrv) = msrv_attr.value_str() else {
202+
sess.dcx().span_err(msrv_attr.span(), "bad clippy attribute");
203+
return None;
204+
};
205205

206+
let Some(version) = parse_version(msrv) else {
206207
sess.dcx()
207208
.span_err(msrv_attr.span(), format!("`{msrv}` is not a valid Rust version"));
208-
} else {
209-
sess.dcx().span_err(msrv_attr.span(), "bad clippy attribute");
210-
}
209+
return None;
210+
};
211211

212-
None
212+
Some(version)
213213
}

0 commit comments

Comments
 (0)