Skip to content

Commit 06ae29a

Browse files
authored
fix: adjust replicated network report cli usage in test (#2968)
1 parent 2a36974 commit 06ae29a

File tree

1 file changed

+7
-21
lines changed

1 file changed

+7
-21
lines changed

e2e/cluster/cmx/cluster.go

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ type Network struct {
4848
ID string `json:"id"`
4949
}
5050

51+
type NetworkReport struct {
52+
Events []NetworkEvent `json:"events"`
53+
}
54+
5155
type NetworkEvent struct {
5256
Timestamp time.Time `json:"timestamp"`
5357
PID int `json:"pid"`
@@ -608,33 +612,15 @@ func (c *Cluster) waitUntilRunning(node Node, nodeNum int, timeoutDuration time.
608612
}
609613

610614
func (c *Cluster) CollectNetworkReport() ([]NetworkEvent, error) {
611-
output, err := exec.Command("replicated", "network", "report", fmt.Sprintf("--id=%v", c.network.ID), "-ojson").Output()
615+
output, err := exec.Command("replicated", "network", "report", fmt.Sprintf("--id=%v", c.network.ID)).Output()
612616
if err != nil {
613617
return nil, fmt.Errorf("collect network report: %v", err)
614618
}
615619

616-
type eventWrapper struct {
617-
EventData string `json:"event_data"`
618-
}
619-
620-
type networkReport struct {
621-
Events []eventWrapper `json:"events"`
622-
}
623-
624-
report := networkReport{}
620+
report := NetworkReport{}
625621
if err := json.Unmarshal(output, &report); err != nil {
626622
return nil, fmt.Errorf("unmarshal network events: %v", err)
627623
}
628624

629-
networkEvents := make([]NetworkEvent, 0, len(report.Events))
630-
for _, e := range report.Events {
631-
ne := NetworkEvent{}
632-
if err := json.Unmarshal([]byte(e.EventData), &ne); err != nil {
633-
return nil, fmt.Errorf("unmarshal network event data: %v", err)
634-
}
635-
636-
networkEvents = append(networkEvents, ne)
637-
}
638-
639-
return networkEvents, nil
625+
return report.Events, nil
640626
}

0 commit comments

Comments
 (0)