Merge branch 'main' into rest-data-docs

Author: DoguhanOzgurAkca

.changeset/five-fans-swim.md

@@ -0,0 +1,8 @@
+---
+"@refinedev/react-hook-form": patch
+---
+
+- Add useEffect to set form values from initial query result when modal is visible.
+- Compensates for useForm not setting initial modal form values when querying the same resource id back-to-back.
+
+[Resolves #6904](https://github.com/refinedev/refine/issues/6904)

.changeset/nice-papayas-care.md

@@ -0,0 +1,11 @@
+---
+"@refinedev/core": patch
+---
+
+fix: use stable array to prevent memoization issue in useList. #7019
+
+Fixed an issue where `useList`, `useMany`, `useTable`, and `useCustom` hooks created new empty arrays/objects on every render. This caused `useEffect` and `useMemo` to trigger unnecessarily.
+
+Now these hooks use stable references for better performance.
+
+Fixes #7019

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -34,11 +34,8 @@ body:
   - type: textarea
     attributes:
       label: Packages
-      description: Mention the Refine packages you are using and their versions.
-      placeholder: |
-        - @refinedev/antd
-        - @refinedev/nextjs-router
-        - @refinedev/simple-rest
+      description: Run `npm run refine whoami` script and paste the result here.
+      placeholder: Run `npm run refine whoami` script and paste the result here.
     validations:
       required: true
 

documentation/blog/2024-11-27-git-delete.md

@@ -8,7 +8,7 @@ image: https://refine.ams3.cdn.digitaloceanspaces.com/blog/2022-11-27-git-delete
 hide_table_of_contents: false
 ---
 
-**This article was last updated on November 27, 2024, to short explanations for git deleote local and remote branches.**
+**This article was last updated on September 26, 2025 to include branch protection policies and team best practices for safe deletion.**
 
 ## Introduction
 
@@ -336,6 +336,14 @@ Similarly if you want to specify the deletion of tags and not branch, then use b
 git push origin :refs/tags/tag-name
 ```
 
+## Branch Protection and Pre-Delete Hooks
+
+To avoid accidental removal of important branches such as `main`, `develop`, or long-lived release lines, modern platforms like GitHub and GitLab offer **branch protection rules**. These rules can block deletion, require pull request reviews, or enforce status checks before changes are merged. Combined with local safeguards, teams can also configure **pre-push or pre-delete Git hooks** that run before destructive actions. For example, a hook could refuse to delete a branch unless a team lead approves, or it could stop pushes that target protected branches. These practices make it harder for human error to remove branches that are still in use or critical to deployment pipelines.
+
+## Best Practices for Teams
+
+When multiple developers are working on the same repository, branch cleanup becomes more than a personal workflow—it’s a team-wide responsibility. A good practice is to schedule periodic reviews of stale branches, ideally at sprint boundaries or release milestones, so old feature branches don’t pile up. Communication also matters: announcing deletions in a team channel helps avoid surprises, especially when others may still be referencing those branches. Tools like `git show-branch`, `git branch --merged`, or GitHub’s branch dashboard can help verify whether a branch is truly inactive before removal. By treating cleanup as part of the collaboration process, teams reduce friction and ensure that only safe, unnecessary branches are deleted.
+
 ## Conclusion
 
 In this article, we learned about the different ways to delete a branch in Git also answered frequently asked questions related to deleting a branch in Git.

packages/core/src/hooks/data/useCustom.ts

@@ -114,6 +114,8 @@ export type UseCustomReturnType<TData, TError> = {
   };
 } & UseLoadingOvertimeReturnType;
 
+const EMPTY_OBJECT = Object.freeze({}) as any;
+
 export const useCustom = <
   TQueryFnData extends BaseRecord = BaseRecord,
   TError extends HttpError = HttpError,
@@ -231,7 +233,7 @@ export const useCustom = <
     return {
       query: queryResponse,
       result: {
-        data: queryResponse.data?.data || ({} as TData),
+        data: queryResponse.data?.data || EMPTY_OBJECT,
       },
       overtime: { elapsedTime },
     };

packages/core/src/hooks/data/useList.ts

@@ -101,6 +101,8 @@ export type UseListReturnType<TData, TError> = {
   };
 } & UseLoadingOvertimeReturnType;
 
+const EMPTY_ARRAY = Object.freeze([]) as [];
+
 /**
  * `useList` is a modified version of `react-query`'s {@link https://tanstack.com/query/v5/docs/framework/react/guides/queries `useQuery`} used for retrieving items from a `resource` with pagination, sort, and filter configurations.
  *
@@ -315,7 +317,7 @@ export const useList = <
   return {
     query: queryResponse,
     result: {
-      data: queryResponse?.data?.data || [],
+      data: queryResponse?.data?.data || EMPTY_ARRAY,
       total: queryResponse?.data?.total,
     },
     overtime: { elapsedTime },

packages/core/src/hooks/data/useMany.ts

@@ -85,6 +85,8 @@ export type UseManyProps<TQueryFnData, TError, TData> = {
   LiveModeProps &
   UseLoadingOvertimeOptionsProps;
 
+const EMPTY_ARRAY = Object.freeze([]) as [];
+
 /**
  * `useMany` is a modified version of `react-query`'s {@link https://tanstack.com/query/v5/docs/framework/react/guides/queries `useQuery`} used for retrieving multiple items from a `resource`.
  *
@@ -259,7 +261,7 @@ export const useMany = <
   return {
     query: queryResponse,
     result: {
-      data: queryResponse?.data?.data || [],
+      data: queryResponse?.data?.data || EMPTY_ARRAY,
     },
     overtime: { elapsedTime },
   };

packages/core/src/hooks/useTable/index.ts

@@ -176,6 +176,7 @@ export type useTableReturnType<
 
 const defaultPermanentFilter: CrudFilter[] = [];
 const defaultPermanentSorter: CrudSort[] = [];
+const EMPTY_ARRAY = Object.freeze([]) as [];
 
 export function useTable<
   TQueryFnData extends BaseRecord = BaseRecord,
@@ -434,7 +435,7 @@ export function useTable<
     createLinkForSyncWithLocation,
     overtime: queryResult.overtime,
     result: {
-      data: queryResult.result?.data || [],
+      data: queryResult.result?.data || EMPTY_ARRAY,
       total: queryResult.result?.total,
     },
   };

packages/react-hook-form/src/useModalForm/index.spec.ts

@@ -291,11 +291,16 @@ describe("useModalForm Hook", () => {
 
     await act(async () => {
       result.current.modal.show();
+    });
+
+    await act(async () => {
       // register values to form
       result.current.register("test");
       result.current.setValue("test", "test");
     });
 
+    expect(result.current.getValues()).toStrictEqual({ test: "test" });
+
     await act(async () => {
       result.current.modal.close();
     });
@@ -350,20 +355,36 @@ describe("useModalForm Hook", () => {
           },
         }),
       {
-        wrapper: TestWrapper({}),
+        wrapper: TestWrapper({
+          dataProvider: {
+            ...MockJSONServer,
+            getOne: () =>
+              Promise.resolve({ data: { id: 5, title: "default-title" } }),
+          },
+        }),
       },
     );
 
     await act(async () => {
       result.current.modal.show();
-      result.current.register("test");
-      result.current.setValue("test", "test");
+    });
+
+    await act(async () => {
+      result.current.setValue("title", "new-title");
+    });
+
+    expect(result.current.getValues()).toStrictEqual({
+      id: 5,
+      title: "new-title",
     });
 
     await act(async () => {
       result.current.modal.close();
     });
 
-    expect(result.current.getValues()).toStrictEqual({});
+    expect(result.current.getValues()).toStrictEqual({
+      id: 5,
+      title: "default-title",
+    });
   });
 });

packages/react-hook-form/src/useModalForm/index.ts

@@ -64,11 +64,11 @@ export type UseModalFormProps<
   /**
      * @description Configuration object for the modal.
      * `defaultVisible`: Initial visibility state of the modal.
-     * 
+     *
      * `autoSubmitClose`: Whether the form should be submitted when the modal is closed.
-     * 
+     *
      * `autoResetForm`: Whether the form should be reset when the form is submitted.
-     * 
+     *
      * `autoResetFormWhenClose`: Whether the form should be reset to defaultValues when the modal is closed.
      * @type `{
       defaultVisible?: boolean;
@@ -176,7 +176,7 @@ export const useModalForm = <
 
   const {
     reset,
-    refineCore: { onFinish, id, setId, autoSaveProps },
+    refineCore: { onFinish, id, setId, autoSaveProps, query },
     saveButtonProps,
     handleSubmit,
   } = useHookFormResult;
@@ -185,6 +185,20 @@ export const useModalForm = <
     defaultVisible,
   });
 
+  // compensate for setting of initial form values in useForm since it doesnt track modal visibility
+  React.useEffect(() => {
+    if (!visible || !query?.data?.data) return;
+
+    const formData = query.data.data;
+    if (!formData) return;
+
+    reset(formData as any, {
+      ...(!autoResetFormWhenClose && {
+        keepDirtyValues: true,
+      }),
+    });
+  }, [visible, query?.data?.data, autoResetFormWhenClose]);
+
   React.useEffect(() => {
     if (initiallySynced === false && syncWithLocationKey) {
       const openStatus = parsed?.params?.[syncWithLocationKey]?.open;