fix: remove starting packager from build-* commands

Author: szymonrybczak

packages/cli-platform-android/src/commands/buildAndroid/index.ts

@@ -11,13 +11,11 @@ import adb from '../runAndroid/adb';
 import getAdbPath from '../runAndroid/getAdbPath';
 import {getTaskNames} from '../runAndroid/getTaskNames';
 import {promptForTaskSelection} from '../runAndroid/listAndroidTasks';
-import {runPackager} from '@react-native-community/cli-plugin-metro';
 
 export interface BuildFlags {
   mode?: string;
   variant?: string;
   activeArchOnly?: boolean;
-  packager?: boolean;
   port: number;
   terminal?: string;
   tasks?: Array<string>;
@@ -89,14 +87,6 @@ async function buildAndroid(
     }
   }
 
-  await runPackager(
-    args.port,
-    config.root,
-    config.reactNativePath,
-    args.terminal,
-    args.packager,
-  );
-
   return build(gradleArgs, androidProject.sourceDir);
 }
 
@@ -126,10 +116,6 @@ export const options = [
     description:
       "Specify your app's build variant. Deprecated! Use 'mode' instead",
   },
-  {
-    name: '--no-packager',
-    description: 'Do not launch packager while building',
-  },
   {
     name: '--port <number>',
     default: process.env.RCT_METRO_PORT || 8081,

packages/cli-platform-android/src/commands/runAndroid/index.ts

@@ -24,6 +24,7 @@ import {promptForTaskSelection} from './listAndroidTasks';
 import {getTaskNames} from './getTaskNames';
 import {checkUsers, promptForUser} from './listAndroidUsers';
 import {runPackager} from '@react-native-community/cli-plugin-metro';
+
 export interface Flags extends BuildFlags {
   appId: string;
   appIdSuffix: string;
@@ -32,6 +33,7 @@ export interface Flags extends BuildFlags {
   listDevices?: boolean;
   binaryPath?: string;
   user?: number | string;
+  packager: boolean;
 }
 
 export type AndroidProject = NonNullable<Config['project']['android']>;
@@ -314,6 +316,10 @@ export default {
       description: 'Id of the User Profile you want to install the app on.',
       parse: Number,
     },
+    {
+      name: '--no-packager',
+      description: 'Do not launch packager while building',
+    },
   ],
 };
 

packages/cli-platform-ios/README.md

@@ -171,10 +171,6 @@ Explicitly set device to use by name. The value is not required if you have a si
 
 Explicitly set device to use by udid.
 
-#### `--no-packager`
-
-Do not launch packager while building.
-
 #### `--verbose`
 
 Do not use `xcbeautify` or `xcpretty` even if installed.

packages/cli-platform-ios/src/commands/buildIOS/buildProject.ts

@@ -1,7 +1,4 @@
-import child_process, {
-  ChildProcess,
-  SpawnOptionsWithoutStdio,
-} from 'child_process';
+import child_process, {ChildProcess} from 'child_process';
 import chalk from 'chalk';
 import {IOSProjectInfo} from '@react-native-community/cli-types';
 import {
@@ -14,7 +11,6 @@ import {
 export type BuildFlags = {
   mode: string;
   target: string;
-  packager: boolean;
   verbose: boolean;
   xcconfig?: string;
   buildFolder?: string;
@@ -72,11 +68,7 @@ export function buildProject(
         });
       }
     }
-    const buildProcess = child_process.spawn(
-      'xcodebuild',
-      xcodebuildArgs,
-      getProcessOptions(args),
-    );
+    const buildProcess = child_process.spawn('xcodebuild', xcodebuildArgs);
     let buildOutput = '';
     let errorOutput = '';
     buildProcess.stdout.on('data', (data: Buffer) => {
@@ -149,31 +141,3 @@ function xcprettyAvailable() {
   }
   return true;
 }
-
-function getProcessOptions({
-  packager,
-  terminal,
-  port,
-}: {
-  packager: boolean;
-  terminal?: string;
-  port: number;
-}): SpawnOptionsWithoutStdio {
-  if (packager) {
-    return {
-      env: {
-        ...process.env,
-        RCT_TERMINAL: terminal,
-        RCT_METRO_PORT: port.toString(),
-      },
-    };
-  }
-
-  return {
-    env: {
-      ...process.env,
-      RCT_TERMINAL: terminal,
-      RCT_NO_LAUNCH_PACKAGER: 'true',
-    },
-  };
-}

packages/cli-platform-ios/src/commands/buildIOS/index.ts

@@ -22,7 +22,6 @@ import {getProjectInfo} from '../../tools/getProjectInfo';
 import {checkIfConfigurationExists} from '../../tools/checkIfConfigurationExists';
 import {getConfigurationScheme} from '../../tools/getConfigurationScheme';
 import listIOSDevices from '../../tools/listIOSDevices';
-import {runPackager} from '@react-native-community/cli-plugin-metro';
 
 export interface FlagsT extends BuildFlags {
   configuration?: string;
@@ -96,23 +95,10 @@ async function buildIOS(_: Array<string>, ctx: Config, args: FlagsT) {
     } "${chalk.bold(xcodeProject.name)}"`,
   );
 
-  await runPackager(
-    args.port,
-    ctx.root,
-    ctx.reactNativePath,
-    args.terminal,
-    args.packager,
-  );
-
-  const extendedArgs = {
-    ...modifiedArgs,
-    packager: false,
-  };
-
   // // No need to load all available devices
   if (!args.device && !args.udid) {
     if (!args.simulator) {
-      return buildProject(xcodeProject, undefined, scheme, extendedArgs);
+      return buildProject(xcodeProject, undefined, scheme, modifiedArgs);
     }
 
     /**
@@ -135,7 +121,7 @@ async function buildIOS(_: Array<string>, ctx: Config, args: FlagsT) {
       xcodeProject,
       selectedSimulator.udid,
       scheme,
-      extendedArgs,
+      modifiedArgs,
     );
   }
 
@@ -157,12 +143,12 @@ async function buildIOS(_: Array<string>, ctx: Config, args: FlagsT) {
       );
     }
 
-    return buildProject(xcodeProject, device.udid, scheme, extendedArgs);
+    return buildProject(xcodeProject, device.udid, scheme, modifiedArgs);
   } else {
     const physicalDevices = devices.filter((d) => d.type !== 'simulator');
     const device = matchingDevice(physicalDevices, args.device);
     if (device) {
-      return buildProject(xcodeProject, device.udid, scheme, extendedArgs);
+      return buildProject(xcodeProject, device.udid, scheme, modifiedArgs);
     }
   }
 }

packages/cli-platform-ios/src/commands/runIOS/index.ts

@@ -34,6 +34,7 @@ export interface FlagsT extends BuildFlags {
   udid?: string;
   binaryPath?: string;
   listDevices?: boolean;
+  packager: boolean;
 }
 
 async function runIOS(_: Array<string>, ctx: Config, args: FlagsT) {

packages/cli-plugin-metro/src/commands/start/runPackager.ts

@@ -11,13 +11,14 @@ export async function runPackager(
   if (!packager) {
     return;
   }
+
   const result = await isPackagerRunning(port);
+
   if (result === 'running') {
     logger.info('JS server already running.');
   } else if (result === 'unrecognized') {
     logger.warn('JS server not recognized, continuing with build...');
-  } else {
-    // result == 'not_running'
+  } else if (result === 'not_running') {
     logger.info('Starting JS server...');
 
     try {