skip resolve warning when present in public folder

Author: theodorton

lib/propshaft/compiler/css_asset_urls.rb

@@ -37,8 +37,14 @@ def asset_url(resolved_path, logical_path, fingerprint, pattern)
       if asset = load_path.find(resolved_path)
         %[url("#{url_prefix}/#{asset.digested_path}#{fingerprint}")]
       else
-        Propshaft.logger.warn "Unable to resolve '#{pattern}' for missing asset '#{resolved_path}' in #{logical_path}"
+        unless public_file?(resolved_path)
+          warn "Unable to resolve '#{pattern}' for missing asset '#{resolved_path}' in #{logical_path}"
+        end
         %[url("#{pattern}")]
       end
     end
+
+    def public_file?(filename)
+      config.public_path && File.exist?(File.join(config.public_path, filename))
+    end
 end

lib/propshaft/railtie.rb

@@ -38,8 +38,9 @@ class Railtie < ::Rails::Railtie
       config.assets.file_watcher ||= app.config.file_watcher
 
       config.assets.relative_url_root ||= app.config.relative_url_root
+      config.assets.public_path ||= app.config.paths["public"].first
       config.assets.output_path ||=
-        Pathname.new(File.join(app.config.paths["public"].first, app.config.assets.prefix))
+        Pathname.new(File.join(config.assets.public_path, app.config.assets.prefix))
       config.assets.manifest_path ||= config.assets.output_path.join(".manifest.json")
 
       ActiveSupport.on_load(:action_view) do

test/fixtures/public/public-file.jpg

@@ -13,6 +13,13 @@ class Propshaft::Compiler::CssAssetUrlsTest < ActiveSupport::TestCase
     }
   end
 
+  def capture_err
+    _, err = capture_io do
+      yield
+    end
+    err.strip
+  end
+
   test "basic" do
     compiled = compile_asset_with_content(%({ background: url(file.jpg); }))
     assert_match(/{ background: url\("\/assets\/foobar\/source\/file-[a-z0-9]{8}.jpg"\); }/, compiled)
@@ -120,8 +127,11 @@ class Propshaft::Compiler::CssAssetUrlsTest < ActiveSupport::TestCase
   end
 
   test "missing asset" do
-    compiled = compile_asset_with_content(%({ background: url("file-not-found.jpg"); }))
-    assert_match(/{ background: url\("file-not-found.jpg"\); }/, compiled)
+    err = capture_err do
+      compiled = compile_asset_with_content(%({ background: url("file-not-found.jpg"); }))
+      assert_match(/{ background: url\("file-not-found.jpg"\); }/, compiled)
+    end
+    assert_equal "Unable to resolve 'file-not-found.jpg' for missing asset 'foobar/source/file-not-found.jpg' in foobar/source/test.css", err.strip
   end
 
   test "relative url root" do
@@ -131,6 +141,15 @@ class Propshaft::Compiler::CssAssetUrlsTest < ActiveSupport::TestCase
     assert_match(/{ background: url\("\/url-root\/assets\/foobar\/source\/file-[a-z0-9]{8}.jpg"\); }/, compiled)
   end
 
+  test "skips warnings for files already present in public folder" do
+    @options.public_path = Pathname.new("#{__dir__}/../../fixtures/public").to_s
+    err = capture_err do
+      compiled = compile_asset_with_content(%({ background: url(/public-file.jpg); }))
+      assert_match(/{ background: url\("\/public-file.jpg"\); }/, compiled)
+    end
+    assert_equal "", err
+  end
+
   private
     def compile_asset_with_content(content)
       root_path    = Pathname.new("#{__dir__}/../../fixtures/assets/vendor")