test: Consolidate playwright nav component test (#1158)

Co-authored-by: Barret Schloerke <[email protected]>

Author: joesho112358

tests/playwright/shiny/components/nav/app.py

@@ -91,7 +91,7 @@ def make_navset(
 
 
 app_ui = ui.page_navbar(
-    *nav_controls("page_navbar"),
+    *nav_controls("page_navbar()"),
     # bg="#0062cc",
     # inverse=True,
     id="page_navbar",

tests/playwright/shiny/components/nav/test_nav.py

@@ -1,3 +1,7 @@
+from __future__ import annotations
+
+from dataclasses import dataclass
+
 import pytest
 from conftest import ShinyAppProc
 from controls import (
@@ -20,75 +24,37 @@ def test_nav(page: Page, local_app: ShinyAppProc) -> None:
     # Update the page size to be wider
     page.set_viewport_size({"width": 1500, "height": 800})
 
-    # make it in a funcn and then loop through it
-    # navset_tab
-    navset_tab = LayoutNavsetTab(page, "navset_tab")
-    navset_tab.expect_nav_values(["a", "b", "c"])
-    navset_tab.expect_value("a")
-    navset_tab.expect_content("navset_tab(): tab a content")
-    navset_tab.set("b")
-    navset_tab.expect_value("b")
-    navset_tab.expect_content("navset_tab(): tab b content")
-
-    # # navset_pill
-    navset_pill = LayoutNavSetPill(page, "navset_pill")
-    navset_pill.expect_nav_values(["a", "b", "c"])
-    navset_pill.expect_value("a")
-    navset_pill.expect_content("navset_pill(): tab a content")
-    navset_pill.set("b")
-    navset_pill.expect_value("b")
-    navset_pill.expect_content("navset_pill(): tab b content")
-
-    # navset_underline
-    navset_underline = LayoutNavSetUnderline(page, "navset_underline")
-    navset_underline.expect_nav_values(["a", "b", "c"])
-    navset_underline.expect_value("a")
-    navset_underline.expect_content("navset_underline(): tab a content")
-    navset_underline.set("b")
-    navset_underline.expect_value("b")
-    navset_underline.expect_content("navset_underline(): tab b content")
-
-    # navset_card_tab
-    navset_card_tab = LayoutNavSetCardTab(page, "navset_card_tab")
-    navset_card_tab.expect_nav_values(["a", "b", "c"])
-    navset_card_tab.expect_value("a")
-    navset_card_tab.expect_content("navset_card_tab(): tab a content")
-    navset_card_tab.set("b")
-    navset_card_tab.expect_value("b")
-    navset_card_tab.expect_content("navset_card_tab(): tab b content")
-
-    # navset_card_pill
-    navset_card_pill = LayoutNavSetCardPill(page, "navset_card_pill")
-    navset_card_pill.expect_nav_values(["a", "b", "c"])
-    navset_card_pill.expect_value("a")
-    navset_card_pill.expect_content("navset_card_pill(): tab a content")
-    navset_card_pill.set("b")
-    navset_card_pill.expect_value("b")
-    navset_card_pill.expect_content("navset_card_pill(): tab b content")
-
-    # navset_card_underline
-    navset_card_underline = LayoutNavSetCardUnderline(page, "navset_card_underline")
-    navset_card_underline.expect_nav_values(["a", "b", "c"])
-    navset_card_underline.expect_value("a")
-    navset_card_underline.expect_content("navset_card_underline(): tab a content")
-    navset_card_underline.set("b")
-    navset_card_underline.expect_value("b")
-    navset_card_underline.expect_content("navset_card_underline(): tab b content")
-
-    # navset_pill_list
-    navset_card_pill = LayoutNavSetPillList(page, "navset_pill_list")
-    navset_card_pill.expect_nav_values(["a", "b", "c"])
-    navset_card_pill.expect_value("a")
-    navset_card_pill.expect_content("navset_pill_list(): tab a content")
-    navset_card_pill.set("b")
-    navset_card_pill.expect_value("b")
-    navset_card_pill.expect_content("navset_pill_list(): tab b content")
-
-    # Page_navbar
-    navset_bar = LayoutNavSetBar(page, "page_navbar")
-    navset_bar.expect_nav_values(["a", "b", "c"])
-    navset_bar.expect_value("a")
-    navset_bar.expect_content("page_navbar: tab a content")
-    navset_bar.set("b")
-    navset_bar.expect_value("b")
-    navset_bar.expect_content("page_navbar: tab b content")
+    @dataclass
+    class LayoutInfo:
+        control: type[
+            LayoutNavSetBar
+            | LayoutNavSetCardPill
+            | LayoutNavSetCardTab
+            | LayoutNavSetCardUnderline
+            | LayoutNavSetPill
+            | LayoutNavSetPillList
+            | LayoutNavsetTab
+            | LayoutNavSetUnderline
+        ]
+        verify: str
+
+    nav_data: list[LayoutInfo] = [
+        LayoutInfo(LayoutNavsetTab, "navset_tab()"),
+        LayoutInfo(LayoutNavSetPill, "navset_pill()"),
+        LayoutInfo(LayoutNavSetUnderline, "navset_underline()"),
+        LayoutInfo(LayoutNavSetCardTab, "navset_card_tab()"),
+        LayoutInfo(LayoutNavSetCardPill, "navset_card_pill()"),
+        LayoutInfo(LayoutNavSetCardUnderline, "navset_card_underline()"),
+        LayoutInfo(LayoutNavSetPillList, "navset_pill_list()"),
+        LayoutInfo(LayoutNavSetBar, "page_navbar()"),
+    ]
+
+    for nav_info in nav_data:
+        el_name = nav_info.verify.replace("()", "")
+        element = nav_info.control(page, el_name)
+        element.expect_nav_values(["a", "b", "c"])
+        element.expect_value("a")
+        element.expect_content(nav_info.verify + ": tab a content")
+        element.set("b")
+        element.expect_value("b")
+        element.expect_content(nav_info.verify + ": tab b content")