Skip to content

Commit 5ba7ef2

Browse files
authored
chore(pyright): Remove version restriction and fix appropriate pyright errors (#1473)
1 parent 9df7c77 commit 5ba7ef2

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ dev =
102102
flake8>=6.0.0
103103
flake8-bugbear>=23.2.13
104104
isort>=5.10.1
105-
pyright==1.1.365 # must be larger than 1.1.366; https://github.com/microsoft/pyright/issues/8087
105+
pyright>=1.1.367
106106
pre-commit>=2.15.0
107107
wheel
108108
matplotlib

shiny/render/transformer/_transformer.py

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -120,17 +120,6 @@ def __init__(self, *args: P.args, **kwargs: P.kwargs) -> None:
120120
self.kwargs = kwargs
121121

122122

123-
def empty_params() -> TransformerParams[P]:
124-
"""
125-
Return `TransformerParams` definition with no parameters.
126-
"""
127-
128-
def inner(*args: P.args, **kwargs: P.kwargs) -> TransformerParams[P]:
129-
return TransformerParams[P](*args, **kwargs)
130-
131-
return inner()
132-
133-
134123
# ======================================================================================
135124
# Renderer / RendererSync / RendererAsync base class
136125
# ======================================================================================
@@ -544,7 +533,9 @@ def __call__(
544533
params: TransformerParams[P] | None = None,
545534
) -> OutputRenderer[OT] | OutputRendererDecorator[IT, OT]:
546535
if params is None:
547-
params = self.params()
536+
params = (
537+
self.params()
538+
) # pyright: ignore[reportCallIssue] ; Missing param spec args; False positive error as we know there should be no args.
548539
if not isinstance(params, TransformerParams):
549540
raise TypeError(
550541
"Expected `params` to be of type `TransformerParams` but received "
@@ -560,7 +551,10 @@ def __init__(
560551
self._fn = fn
561552
self.ValueFn = ValueFn[IT]
562553
self.OutputRenderer = OutputRenderer[OT]
563-
self.OutputRendererDecorator = OutputRendererDecorator[IT, OT]
554+
555+
self.OutputRendererDecorator = OutputRendererDecorator[
556+
IT, OT
557+
] # pyright: ignore[reportAttributeAccessIssue] ; False positive error as the types should match the class definition. Not worrying about it as this code is deprecated.
564558

565559

566560
@overload

0 commit comments

Comments
 (0)