Skip to content

Commit a70e216

Browse files
liruohrhcanstand
andauthored
test: wait for workerFunction to be defined in worker test (#561)
* test: wait for workerFunction to be defined in worker test * test: page workers may not immediately available in macos --------- Co-authored-by: canstand <[email protected]>
1 parent 2943f90 commit a70e216

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

tests/page_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,15 @@ func TestPageExpectWorker(t *testing.T) {
258258
require.Equal(t, worker, page.Workers()[0])
259259
worker = page.Workers()[0]
260260
require.Contains(t, worker.URL(), "worker.js")
261+
// flaky in the macos-latest of gh action
262+
require.Eventually(t,
263+
func() bool {
264+
v, err := worker.Evaluate(`() => self["workerFunction"] ? true : false`)
265+
require.NoError(t, err)
266+
return v == true
267+
},
268+
500*time.Millisecond, 10*time.Millisecond,
269+
)
261270
res, err := worker.Evaluate(`() => self["workerFunction"]()`)
262271
require.NoError(t, err)
263272
require.Equal(t, "worker function result", res)

tests/worker_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package playwright_test
22

33
import (
44
"testing"
5+
"time"
56

67
"github.com/playwright-community/playwright-go"
78
"github.com/stretchr/testify/require"
@@ -19,6 +20,15 @@ func TestWorkerShouldWork(t *testing.T) {
1920
require.Equal(t, worker, page.Workers()[0])
2021
worker = page.Workers()[0]
2122
require.Contains(t, worker.URL(), "worker.js")
23+
// flaky in the macos-latest of gh action
24+
require.Eventually(t,
25+
func() bool {
26+
v, err := worker.Evaluate(`() => self["workerFunction"] ? true : false`)
27+
require.NoError(t, err)
28+
return v == true
29+
},
30+
500*time.Millisecond, 10*time.Millisecond,
31+
)
2232
res, err := worker.Evaluate(`() => self["workerFunction"]()`)
2333
require.NoError(t, err)
2434
require.Equal(t, "worker function result", res)

0 commit comments

Comments
 (0)