Skip to content

Commit 5b5d254

Browse files
committed
fix: parameter name shadows function
1 parent 46e0f5a commit 5b5d254

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

builder/penv_setup.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -415,18 +415,18 @@ def setup_penv_minimal(platform, platformio_dir, install_esptool=True):
415415
Raises:
416416
SystemExit: If Python version < 3.10 or dependency installation fails
417417
"""
418-
return _setup_python_environment_core(None, platform, platformio_dir, install_esptool)
418+
return _setup_python_environment_core(None, platform, platformio_dir, should_install_esptool=install_esptool)
419419

420420

421-
def _setup_python_environment_core(env, platform, platformio_dir, install_esptool=True):
421+
def _setup_python_environment_core(env, platform, platformio_dir, should_install_esptool=True):
422422
"""
423423
Core Python environment setup logic shared by both SCons and minimal versions.
424424
425425
Args:
426426
env: SCons environment object (None for minimal setup)
427427
platform: PlatformIO platform object
428428
platformio_dir (str): Path to PlatformIO core directory
429-
install_esptool (bool): Whether to install esptool (default: True)
429+
should_install_esptool (bool): Whether to install esptool (default: True)
430430
431431
Returns:
432432
tuple[str, str]: (Path to penv Python executable, Path to esptool script)
@@ -476,7 +476,7 @@ def _setup_python_environment_core(env, platform, platformio_dir, install_esptoo
476476
print("Warning: No internet connection detected, Python dependency check will be skipped.")
477477

478478
# Install esptool after dependencies (if requested)
479-
if install_esptool:
479+
if should_install_esptool:
480480
if env is not None:
481481
# SCons version
482482
install_esptool(env, platform, penv_python, uv_executable)
@@ -648,4 +648,4 @@ def setup_python_environment(env, platform, platformio_dir):
648648
Raises:
649649
SystemExit: If Python version < 3.10 or dependency installation fails
650650
"""
651-
return _setup_python_environment_core(env, platform, platformio_dir, install_esptool=True)
651+
return _setup_python_environment_core(env, platform, platformio_dir, should_install_esptool=True)

0 commit comments

Comments
 (0)