Add withSideEffects:null to RemoveUnusedLocalVariables

timtebeek · timtebeek · commit 3e98d8530a2e · 2024-10-23T12:14:34.000+02:00
diff --git a/src/main/java/org/openrewrite/java/migrate/jakarta/RemoveBeanIsNullable.java b/src/main/java/org/openrewrite/java/migrate/jakarta/RemoveBeanIsNullable.java
@@ -50,7 +50,7 @@ public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx)
                 if (BEAN_ISNULLABLE.matches(method)) {
                     // clean up leftover conditions and remove unused variables
                     doAfterVisit(new SimplifyConstantIfBranchExecution().getVisitor());
-                    doAfterVisit(new RemoveUnusedLocalVariables(null).getVisitor());
+                    doAfterVisit(new RemoveUnusedLocalVariables(null, null).getVisitor());
                     return new J.Literal(randomId(), Space.SINGLE_SPACE, Markers.EMPTY, Boolean.FALSE, "false", null, JavaType.Primitive.Boolean);
                 }
                 return super.visitMethodInvocation(method, ctx);

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx)`
`50`	`50`	`if (BEAN_ISNULLABLE.matches(method)) {`
`51`	`51`	`// clean up leftover conditions and remove unused variables`
`52`	`52`	`doAfterVisit(new SimplifyConstantIfBranchExecution().getVisitor());`
`53`		`- doAfterVisit(new RemoveUnusedLocalVariables(null).getVisitor());`
	`53`	`+ doAfterVisit(new RemoveUnusedLocalVariables(null, null).getVisitor());`
`54`	`54`	`return new J.Literal(randomId(), Space.SINGLE_SPACE, Markers.EMPTY, Boolean.FALSE, "false", null, JavaType.Primitive.Boolean);`
`55`	`55`	`}`
`56`	`56`	`return super.visitMethodInvocation(method, ctx);`