PR feedback

Author: JamesNK

docs/dotnet/dotnet-aspnetcore-metrics.md

@@ -375,7 +375,7 @@ Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability | Entity Associations |
 | -------- | --------------- | ----------- | -------------- | --------- | ------ |
-| `aspnetcore.authentication.challenges` | Counter | `{request}` | The total number of times a scheme is challenged. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
+| `aspnetcore.authentication.challenges` | Counter | `{challenge}` | The total number of times a scheme is challenged. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
 
 **[1]:** Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
 
@@ -408,7 +408,7 @@ Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability | Entity Associations |
 | -------- | --------------- | ----------- | -------------- | --------- | ------ |
-| `aspnetcore.authentication.forbids` | Counter | `{request}` | The total number of times an authenticated user attempts to access a resource they are not permitted to access. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
+| `aspnetcore.authentication.forbids` | Counter | `{forbid}` | The total number of times an authenticated user attempts to access a resource they are not permitted to access. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
 
 **[1]:** Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
 
@@ -441,7 +441,7 @@ Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability | Entity Associations |
 | -------- | --------------- | ----------- | -------------- | --------- | ------ |
-| `aspnetcore.authentication.sign_ins` | Counter | `{request}` | The total number of times a principal is signed in with a scheme. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
+| `aspnetcore.authentication.sign_ins` | Counter | `{sign_in}` | The total number of times a principal is signed in with a scheme. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
 
 **[1]:** Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
 
@@ -474,7 +474,7 @@ Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability | Entity Associations |
 | -------- | --------------- | ----------- | -------------- | --------- | ------ |
-| `aspnetcore.authentication.sign_outs` | Counter | `{request}` | The total number of times a principal is signed out with a scheme. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
+| `aspnetcore.authentication.sign_outs` | Counter | `{sign_out}` | The total number of times a principal is signed out with a scheme. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
 
 **[1]:** Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
 
@@ -509,13 +509,13 @@ Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
 
 | Name     | Instrument Type | Unit (UCUM) | Description    | Stability | Entity Associations |
 | -------- | --------------- | ----------- | -------------- | --------- | ------ |
-| `aspnetcore.authorization.attempts` | Counter | `{request}` | The total number of requests for which authorization was attempted. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
+| `aspnetcore.authorization.attempts` | Counter | `{attempt}` | The total number of authorization attempts. [1] | ![Development](https://img.shields.io/badge/-development-blue) |  |
 
 **[1]:** Meter name: `Microsoft.AspNetCore.Authorization`; Added in: ASP.NET Core 10.0
 
 | Attribute  | Type | Description  | Examples  | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
 |---|---|---|---|---|---|
-| [`user.is_authenticated`](/docs/registry/attributes/aspnetcore.md) | boolean | A value that indicates whether the user is authenticated. | `true` | `Required` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
+| [`aspnetcore.user.is_authenticated`](/docs/registry/attributes/aspnetcore.md) | boolean | A value that indicates whether the user is authenticated. | `true` | `Required` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
 | [`aspnetcore.authorization.policy`](/docs/registry/attributes/aspnetcore.md) | string | The name of the authorization policy. | `RequireAdminRole` | `Conditionally Required` if a policy is specified. | ![Development](https://img.shields.io/badge/-development-blue) |
 | [`aspnetcore.authorization.result`](/docs/registry/attributes/aspnetcore.md) | string | The result of calling the authorization service. | `success`; `failure` | `Conditionally Required` if no exception was thrown. | ![Development](https://img.shields.io/badge/-development-blue) |
 | [`error.type`](/docs/registry/attributes/error.md) | string | The full name of exception type. | `System.OperationCanceledException` | `Conditionally Required` if and only if an error has occurred. | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |

docs/registry/attributes/aspnetcore.md

@@ -20,7 +20,7 @@ ASP.NET Core attributes
 | <a id="aspnetcore-request-is-unhandled" href="#aspnetcore-request-is-unhandled">`aspnetcore.request.is_unhandled`</a> | boolean | Flag indicating if request was handled by the application pipeline. | `true` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
 | <a id="aspnetcore-routing-is-fallback" href="#aspnetcore-routing-is-fallback">`aspnetcore.routing.is_fallback`</a> | boolean | A value that indicates whether the matched route is a fallback route. | `true` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
 | <a id="aspnetcore-routing-match-status" href="#aspnetcore-routing-match-status">`aspnetcore.routing.match_status`</a> | string | Match result - success or failure | `success`; `failure` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
-| <a id="user-is-authenticated" href="#user-is-authenticated">`user.is_authenticated`</a> | boolean | A value that indicates whether the user is authenticated. | `true` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
+| <a id="aspnetcore-user-is-authenticated" href="#aspnetcore-user-is-authenticated">`aspnetcore.user.is_authenticated`</a> | boolean | A value that indicates whether the user is authenticated. | `true` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
 
 ---
 

model/aspnetcore/metrics.yaml

@@ -175,7 +175,7 @@ groups:
     stability: development
     brief: The total number of times a scheme is challenged.
     instrument: counter
-    unit: "{request}"
+    unit: "{challenge}"
     note: |
       Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
     extends: aspnetcore.common.authentication.metrics.attributes
@@ -189,7 +189,7 @@ groups:
     stability: development
     brief: The total number of times an authenticated user attempts to access a resource they are not permitted to access.
     instrument: counter
-    unit: "{request}"
+    unit: "{forbid}"
     note: |
       Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
     extends: aspnetcore.common.authentication.metrics.attributes
@@ -203,7 +203,7 @@ groups:
     stability: development
     brief: The total number of times a principal is signed in with a scheme.
     instrument: counter
-    unit: "{request}"
+    unit: "{sign_in}"
     note: |
       Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
     extends: aspnetcore.common.authentication.metrics.attributes
@@ -217,7 +217,7 @@ groups:
     stability: development
     brief: The total number of times a principal is signed out with a scheme.
     instrument: counter
-    unit: "{request}"
+    unit: "{sign_out}"
     note: |
       Meter name: `Microsoft.AspNetCore.Authentication`; Added in: ASP.NET Core 10.0
     extends: aspnetcore.common.authentication.metrics.attributes
@@ -229,13 +229,13 @@ groups:
       code_generation:
         metric_value_type: int
     stability: development
-    brief: The total number of requests for which authorization was attempted.
+    brief: The total number of authorization attempts.
     instrument: counter
-    unit: "{request}"
+    unit: "{attempt}"
     note: |
       Meter name: `Microsoft.AspNetCore.Authorization`; Added in: ASP.NET Core 10.0
     attributes:
-      - ref: user.is_authenticated
+      - ref: aspnetcore.user.is_authenticated
         requirement_level: required
       - ref: aspnetcore.authorization.policy
         requirement_level:

model/aspnetcore/registry.yaml

@@ -106,7 +106,7 @@ groups:
         stability: development
         brief: The identifier that names a particular authentication handler.
         examples: ["Cookies", "Bearer", "Identity.Application"]
-      - id: user.is_authenticated
+      - id: aspnetcore.user.is_authenticated
         type: boolean
         stability: stable
         brief: A value that indicates whether the user is authenticated.