Skip to content

Conversation

askpt
Copy link
Member

@askpt askpt commented Apr 16, 2025

This PR

This pull request includes updates to several GitHub Actions workflows to add permissions for reading contents and writing pull requests. Additionally, there is a minor change to the lint-pr.yml workflow file to standardize the quotation marks used in the name field.

Workflow permissions updates:

Standardization:

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (73207d0) to head (c99bf1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files          39       39           
  Lines        1601     1601           
  Branches      171      171           
=======================================
  Hits         1372     1372           
  Misses        191      191           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem right to me.

@toddbaert toddbaert self-requested a review April 16, 2025 15:52
@askpt askpt marked this pull request as ready for review April 16, 2025 15:54
@askpt askpt requested a review from a team as a code owner April 16, 2025 15:54
Copy link

@kriscoleman kriscoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@beeme1mr beeme1mr added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 568722a Apr 17, 2025
18 checks passed
@askpt askpt deleted the askpt/fix-ci-permissions branch April 17, 2025 15:40
github-merge-queue bot pushed a commit that referenced this pull request Apr 28, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.5.0](v2.4.0...v2.5.0)
(2025-04-25)


### ✨ New Features

* Add support for hook data.
([#387](#387))
([4563512](4563512))


### 🧹 Chore

* add NuGet auditing
([#454](#454))
([42ab536](42ab536))
* Change file scoped namespaces and cleanup job
([#453](#453))
([1e74a04](1e74a04))
* **deps:** update codecov/codecov-action action to v5.4.2
([#432](#432))
([c692ec2](c692ec2))
* **deps:** update github/codeql-action digest to 28deaed
([#446](#446))
([dfecd0c](dfecd0c))
* **deps:** update spec digest to 18cde17
([#395](#395))
([5608dfb](5608dfb))
* **deps:** update spec digest to 2ba05d8
([#452](#452))
([eb688c4](eb688c4))
* **deps:** update spec digest to 36944c6
([#450](#450))
([e162169](e162169))
* **deps:** update spec digest to d27e000
([#455](#455))
([e0ec8ca](e0ec8ca))
* packages read in release please
([1acc00f](1acc00f))
* update release permissions
([d0bf40b](d0bf40b))
* **workflows:** Add permissions for contents and pull-requests
([#439](#439))
([568722a](568722a))


### 📚 Documentation

* update documentation on SetProviderAsync
([#449](#449))
([858b286](858b286))
* Update README with spec version
([#437](#437))
([7318b81](7318b81)),
closes [#204](#204)


### 🔄 Refactoring

* InMemoryProvider throwing when types mismatched
([#442](#442))
([8ecf50d](8ecf50d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
WeihanLi pushed a commit to WeihanLi/openfeature-dotnet-sdk that referenced this pull request May 14, 2025
…n-feature#439)

<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

This pull request includes updates to several GitHub Actions workflows
to add permissions for reading contents and writing pull requests.
Additionally, there is a minor change to the `lint-pr.yml` workflow file
to standardize the quotation marks used in the `name` field.

Workflow permissions updates:

*
[`.github/workflows/ci.yml`](diffhunk://#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR15-R17):
Added permissions for reading contents and writing pull requests to the
`build` job.
*
[`.github/workflows/code-coverage.yml`](diffhunk://#diff-49708f979e226a1e7bd7a68d71b2e91aae8114dd3e9254d9830cd3b4d62d4303R15-R17):
Added permissions for reading contents and writing pull requests to the
`build-test-report` job.
*
[`.github/workflows/dco-merge-group.yml`](diffhunk://#diff-cbf8f01aa06b4aa3d0729c5bce44e4f919c801b55f19a781b15f62aa10e68e90R10-R12):
Added permissions for reading contents and writing pull requests to the
`DCO` job.
*
[`.github/workflows/dotnet-format.yml`](diffhunk://#diff-ca8c2611c79b991c0fbe04fec3c97c14dc83419f5efb1e8a7a96dd51e7df3e2aR12-R14):
Added permissions for reading contents and writing pull requests to the
`check-format` job.
*
[`.github/workflows/e2e.yml`](diffhunk://#diff-3e103440521ada06efd263ae09b259e5507e4b8f7408308dc227621ad9efa31eR16-R18):
Added permissions for reading contents and writing pull requests to the
`e2e-tests` job.
*
[`.github/workflows/lint-pr.yml`](diffhunk://#diff-70c3a017bfdb629fd50281fe5f7ad22e29c0ddac36e7065e9dc6d4f0924104f4R14-R16):
Added permissions for reading contents and writing pull requests to the
`main` job.

Standardization:

*
[`.github/workflows/lint-pr.yml`](diffhunk://#diff-70c3a017bfdb629fd50281fe5f7ad22e29c0ddac36e7065e9dc6d4f0924104f4L1-R1):
Changed single quotes to double quotes in the `name` field.

Signed-off-by: André Silva <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
WeihanLi pushed a commit to WeihanLi/openfeature-dotnet-sdk that referenced this pull request May 14, 2025
🤖 I have created a release *beep* *boop*
---

##
[2.5.0](open-feature/dotnet-sdk@v2.4.0...v2.5.0)
(2025-04-25)

### ✨ New Features

* Add support for hook data.
([open-feature#387](open-feature#387))
([4563512](open-feature@4563512))

### 🧹 Chore

* add NuGet auditing
([open-feature#454](open-feature#454))
([42ab536](open-feature@42ab536))
* Change file scoped namespaces and cleanup job
([open-feature#453](open-feature#453))
([1e74a04](open-feature@1e74a04))
* **deps:** update codecov/codecov-action action to v5.4.2
([open-feature#432](open-feature#432))
([c692ec2](open-feature@c692ec2))
* **deps:** update github/codeql-action digest to 28deaed
([open-feature#446](open-feature#446))
([dfecd0c](open-feature@dfecd0c))
* **deps:** update spec digest to 18cde17
([open-feature#395](open-feature#395))
([5608dfb](open-feature@5608dfb))
* **deps:** update spec digest to 2ba05d8
([open-feature#452](open-feature#452))
([eb688c4](open-feature@eb688c4))
* **deps:** update spec digest to 36944c6
([open-feature#450](open-feature#450))
([e162169](open-feature@e162169))
* **deps:** update spec digest to d27e000
([open-feature#455](open-feature#455))
([e0ec8ca](open-feature@e0ec8ca))
* packages read in release please
([1acc00f](open-feature@1acc00f))
* update release permissions
([d0bf40b](open-feature@d0bf40b))
* **workflows:** Add permissions for contents and pull-requests
([open-feature#439](open-feature#439))
([568722a](open-feature@568722a))

### 📚 Documentation

* update documentation on SetProviderAsync
([open-feature#449](open-feature#449))
([858b286](open-feature@858b286))
* Update README with spec version
([open-feature#437](open-feature#437))
([7318b81](open-feature@7318b81)),
closes [open-feature#204](open-feature#204)

### 🔄 Refactoring

* InMemoryProvider throwing when types mismatched
([open-feature#442](open-feature#442))
([8ecf50d](open-feature@8ecf50d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants