errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER

changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER
from Error to TypeError as a more accurate representation
of the error.

PR-URL: #19808
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Author: davidmarkclements

lib/internal/errors.js

@@ -733,10 +733,8 @@ E('ERR_HTTP2_INVALID_INFO_STATUS',
   'Invalid informational status code: %s', RangeError);
 E('ERR_HTTP2_INVALID_PACKED_SETTINGS_LENGTH',
   'Packed settings length must be a multiple of six', RangeError);
-
-// This should probably be a `TypeError`.
 E('ERR_HTTP2_INVALID_PSEUDOHEADER',
-  '"%s" is an invalid pseudoheader or is used incorrectly', Error);
+  '"%s" is an invalid pseudoheader or is used incorrectly', TypeError);
 E('ERR_HTTP2_INVALID_SESSION', 'The session has been destroyed', Error);
 E('ERR_HTTP2_INVALID_SETTING_VALUE',
   'Invalid value for setting "%s": %s', TypeError, RangeError);

test/parallel/test-http2-info-headers.js

@@ -36,7 +36,7 @@ function onStream(stream, headers, flags) {
     () => stream.additionalHeaders({ ':method': 'POST' }),
     {
       code: 'ERR_HTTP2_INVALID_PSEUDOHEADER',
-      type: Error,
+      type: TypeError,
       message: '":method" is an invalid pseudoheader or is used incorrectly'
     }
   );

test/parallel/test-http2-util-assert-valid-pseudoheader.js

@@ -17,7 +17,7 @@ function isNotError(val) {
 function isError(val) {
   common.expectsError({
     code: 'ERR_HTTP2_INVALID_PSEUDOHEADER',
-    type: Error,
+    type: TypeError,
     message: '":foo" is an invalid pseudoheader or is used incorrectly'
   })(val);
 }