Skip to content

Commit da10f18

Browse files
committed
fix: disable deterministic NuGet packaging which causes failures for users in GMT >0 timezones
Workaround NuGet/Home#7001
1 parent 8398bd6 commit da10f18

File tree

4 files changed

+24
-2
lines changed

4 files changed

+24
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
[See unreleased changes][unreleased].
44

5+
## [v2.4.1]
6+
7+
* Fix [#277] - workaround a bug in NuGet's 'deterministic packaging' feature which causes issues based on your timezone
8+
59
## [v2.4.0]
610

711
* Fix [#227] by [@ejball] - ArgumentEscaper should escape empty string

Directory.Build.targets

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,14 @@
22
<Target Name="UpdateCiSettings" Condition="'$(CI)' == 'true' AND '$(OS)' == 'Windows_NT' AND '$(IsPackable)' == 'true'">
33
<Message Importance="High" Text="##vso[build.updatebuildnumber]$(PackageVersion)" />
44
</Target>
5+
6+
7+
<!-- Workaround https://github.com/NuGet/Home/issues/7001 -->
8+
<Target Name="DisableNuGetDeterministicPackaging"
9+
BeforeTargets="GenerateNuspec"
10+
AfterTargets="CoreCompile">
11+
<PropertyGroup>
12+
<Deterministic>false</Deterministic>
13+
</PropertyGroup>
14+
</Target>
515
</Project>

src/CommandLineUtils/releasenotes.props

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project>
22
<PropertyGroup>
3-
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.0'">
3+
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.1'">
44
Features and bug fixes by some awesome contributors:
55

66
* @IanG: Attributes for files and directories that must not exist
@@ -16,6 +16,10 @@ Other things I fixed:
1616
* Add async methods that accept cancellation tokens
1717
* Handle CTRL+C by default
1818
* Support calling CommandLineApplication.Execute multiple times
19+
20+
2.4.1 hot fix:
21+
* Workaround a bizarre NuGet bug which causes problems for users in Europe and Asia
22+
(see https://github.com/NuGet/Home/issues/8603)
1923
</PackageReleaseNotes>
2024

2125
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.3.4'">

src/Hosting.CommandLine/releasenotes.props

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
<Project>
22
<PropertyGroup>
3-
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.0'">
3+
<PackageReleaseNotes Condition="'$(VersionPrefix)' == '2.4.1'">
44
Changes:
55
* Support C# 8.0 and nullable reference types
66
* RunCommandLineApplicationAsync is actually async now, not just sync disguised as an async API
77
* Better CTRL+C support
8+
9+
2.4.1 hot fix:
10+
* Workaround a bizarre NuGet bug which causes problems for users in Europe and Asia
11+
(see https://github.com/NuGet/Home/issues/8603)
812
</PackageReleaseNotes>
913
<PackageReleaseNotes>$(PackageReleaseNotes)
1014

0 commit comments

Comments
 (0)