Add string extension tests and test value names to CONSTANT_CASE

Author: natemcmaster

src/CommandLineUtils/Attributes/OptionAttribute.cs

@@ -79,14 +79,14 @@ internal CommandOption Configure(CommandLineApplication app, PropertyInfo prop)
                 {
                     LongName = longName,
                     ShortName = longName.Substring(0, 1),
-                    ValueName = prop.Name,
+                    ValueName = prop.Name.ToConstantCase(),
                 };
 
                 option.Template = $"-{option.ShortName}|--{option.LongName}";
 
                 if (option.OptionType != CommandOptionType.NoValue)
                 {
-                    option.Template += $" <{option.ValueName.ToUpperInvariant()}>";
+                    option.Template += $" <{option.ValueName.ToConstantCase()}>";
                 }
             }
 

src/CommandLineUtils/Internal/StringExtensions.cs

@@ -56,5 +56,55 @@ public static string ToKebabCase(this string str)
             }
             return sb.ToString();
         }
+
+        public static string ToConstantCase(this string str)
+        {
+            if (string.IsNullOrEmpty(str))
+            {
+                return str;
+            }
+
+            var sb = new StringBuilder();
+            var i = 0;
+            var addUnderscore = false;
+
+            for (; i < str.Length; i++)
+            {
+                var ch = str[i];
+                if (char.IsLetterOrDigit(ch))
+                {
+                    addUnderscore = !char.IsUpper(ch);
+                    sb.Append(char.ToUpperInvariant(ch));
+                    i++;
+                    break;
+                }
+            }
+
+            for (; i < str.Length; i++)
+            {
+                var ch = str[i];
+                if (char.IsUpper(ch))
+                {
+                    if (addUnderscore)
+                    {
+                        addUnderscore = false;
+                        sb.Append('_');
+                    }
+
+                    sb.Append(char.ToUpperInvariant(ch));
+                }
+                else if (char.IsLetterOrDigit(ch))
+                {
+                    addUnderscore = true;
+                    sb.Append(char.ToUpperInvariant(ch));
+                }
+                else
+                {
+                    addUnderscore = false;
+                    sb.Append('_');
+                }
+            }
+            return sb.ToString();
+        }
     }
 }

test/CommandLineUtils.Tests/ReflectionAppBuilderTests.cs

@@ -324,23 +324,23 @@ public void BindsToStaticPropertiesWithSetterMethod()
         }
 
         [Theory]
-        [InlineData("Option123", "o", "option123")]
-        [InlineData("dWORD", "d", "d-word")]
-        [InlineData("MSBuild", "m", "msbuild")]
-        [InlineData("NoEdit", "n", "no-edit")]
-        [InlineData("SetUpstreamBranch", "s", "set-upstream-branch")]
-        [InlineData("lowerCaseFirst", "l", "lower-case-first")]
-        [InlineData("_field", "f", "field")]
-        [InlineData("__field", "f", "field")]
-        [InlineData("___field", "f", "field")]
-        [InlineData("m_field", "m", "m-field")]
-        [InlineData("m_Field", "m", "m-field")]
-        public void ItDeterminesShortAndLongOptionNames(string propName, string shortName, string longName)
+        [InlineData("Option123", "o", "option123", "OPTION123")]
+        [InlineData("dWORD", "d", "d-word", "D_WORD")]
+        [InlineData("MSBuild", "m", "msbuild", "MSBUILD")]
+        [InlineData("NoEdit", "n", "no-edit", "NO_EDIT")]
+        [InlineData("SetUpstreamBranch", "s", "set-upstream-branch", "SET_UPSTREAM_BRANCH")]
+        [InlineData("lowerCaseFirst", "l", "lower-case-first", "LOWER_CASE_FIRST")]
+        [InlineData("_field", "f", "field", "FIELD")]
+        [InlineData("__field", "f", "field", "FIELD")]
+        [InlineData("___field", "f", "field", "FIELD")]
+        [InlineData("m_field", "m", "m-field", "M_FIELD")]
+        [InlineData("m_Field", "m", "m-field", "M_FIELD")]
+        public void ItDeterminesShortAndLongOptionNames(string propName, string shortName, string longName, string valueName)
         {
             var option = CreateOption(typeof(int), propName);
             Assert.Equal(longName, option.LongName);
             Assert.Equal(shortName, option.ShortName);
-            Assert.Equal(propName, option.ValueName);
+            Assert.Equal(valueName, option.ValueName);
         }
 
         private CommandOption CreateOption(Type propType, string propName)

test/CommandLineUtils.Tests/StringExtensionsTests.cs

@@ -0,0 +1,41 @@
+// Copyright (c) Nate McMaster.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using Xunit;
+
+namespace McMaster.Extensions.CommandLineUtils.Tests
+{
+    public class StringExtensionsTests
+    {
+        [Theory]
+        [InlineData(null, null)]
+        [InlineData("", "")]
+        [InlineData("Option123", "option123")]
+        [InlineData("dWORD", "d-word")]
+        [InlineData("MSBuild", "msbuild")]
+        [InlineData("NoEdit", "no-edit")]
+        [InlineData("SetUpstreamBranch", "set-upstream-branch")]
+        [InlineData("lowerCaseFirst", "lower-case-first")]
+        [InlineData("_field", "field")]
+        [InlineData("__field", "field")]
+        [InlineData("___field", "field")]
+        [InlineData("m_field", "m-field")]
+        [InlineData("m_Field", "m-field")]
+        public void ToKebabCase(string input, string expected)
+        {
+            Assert.Equal(expected, input.ToKebabCase());
+        }
+
+        [Theory]
+        [InlineData(null, null)]
+        [InlineData("", "")]
+        [InlineData("NoEdit", "NO_EDIT")]
+        [InlineData("word", "WORD")]
+        [InlineData("_field", "FIELD")]
+        [InlineData("MSBuildTask", "MSBUILD_TASK")]
+        public void ToConstantCase(string input, string expected)
+        {
+            Assert.Equal(expected, input.ToConstantCase());
+        }
+    }
+}