change min_params default to 1e9

abhi-mosaic · abhi-mosaic · commit 3b40a8caac1a · 2022-10-13T17:49:40.000-07:00
diff --git a/composer/trainer/dist_strategy.py b/composer/trainer/dist_strategy.py
@@ -194,7 +194,7 @@ def prepare_fsdp_module(model: torch.nn.Module, optimizers: Optional[Union[torch
         'BACKWARD_POST': BackwardPrefetch.BACKWARD_POST,
     }
     backward_prefetch = backward_prefetch_map[fsdp_config.get('backward_prefetch', 'BACKWARD_POST').upper()]
-    min_params = int(float(fsdp_config.get('min_params', 1e8)))
+    min_params = int(float(fsdp_config.get('min_params', 1e9)))
     activation_checkpointing = fsdp_config.get('activation_checkpointing', False)
     activation_cpu_offload = fsdp_config.get('activation_cpu_offload', False)
 

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ def prepare_fsdp_module(model: torch.nn.Module, optimizers: Optional[Union[torch`
`194`	`194`	`'BACKWARD_POST': BackwardPrefetch.BACKWARD_POST,`
`195`	`195`	`}`
`196`	`196`	`backward_prefetch = backward_prefetch_map[fsdp_config.get('backward_prefetch', 'BACKWARD_POST').upper()]`
`197`		`- min_params = int(float(fsdp_config.get('min_params', 1e8)))`
	`197`	`+ min_params = int(float(fsdp_config.get('min_params', 1e9)))`
`198`	`198`	`activation_checkpointing = fsdp_config.get('activation_checkpointing', False)`
`199`	`199`	`activation_cpu_offload = fsdp_config.get('activation_cpu_offload', False)`
`200`	`200`