Skip to content

Commit 3af18e5

Browse files
authored
Don't overwrite sys.excepthook in mlflow logger (#3675)
1 parent 835dd76 commit 3af18e5

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

composer/loggers/mlflow_logger.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,10 @@ def _start_mlflow_run(self, state):
301301
)
302302
self.monitor_process.start()
303303

304-
def _global_exception_handler(self, exc_type, exc_value, exc_traceback):
304+
def _global_exception_handler(self, original_excepthook, exc_type, exc_value, exc_traceback):
305305
"""Catch global exception."""
306306
self._global_exception_occurred += 1
307-
sys.__excepthook__(exc_type, exc_value, exc_traceback)
307+
original_excepthook(exc_type, exc_value, exc_traceback)
308308

309309
def init(self, state: State, logger: Logger) -> None:
310310
del logger # unused
@@ -322,7 +322,13 @@ def init(self, state: State, logger: Logger) -> None:
322322
self.run_name += f'-rank{dist.get_global_rank()}'
323323

324324
# Register the global exception handler so that uncaught exception is tracked.
325-
sys.excepthook = self._global_exception_handler
325+
original_excepthook = sys.excepthook
326+
sys.excepthook = lambda exc_type, exc_value, exc_traceback: self._global_exception_handler(
327+
original_excepthook,
328+
exc_type,
329+
exc_value,
330+
exc_traceback,
331+
)
326332
# Start run
327333
if self._enabled:
328334
self._start_mlflow_run(state)

0 commit comments

Comments
 (0)