Skip to content

Commit 129dcbe

Browse files
dependabot[bot]Saaketh Narayanmvpatel2000
authored
Update wandb requirement from <0.18,>=0.13.2 to >=0.13.2,<0.19 (#3615)
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Saaketh Narayan <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
1 parent 893f398 commit 129dcbe

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def package_files(prefix: str, directory: str, extension: str):
160160
]
161161

162162
extra_deps['wandb'] = [
163-
'wandb>=0.13.2,<0.18',
163+
'wandb>=0.13.2,<0.19',
164164
]
165165

166166
extra_deps['comet_ml'] = [

tests/loggers/test_wandb_logger.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,10 +269,10 @@ def test_wandb_log_metrics(test_wandb_logger):
269269
eval_metrics_cross_entropy_count = all_run_text.count('metrics/eval/CrossEntropy')
270270
train_loss_count = all_run_text.count('loss/train/total')
271271

272-
expected_number_train_loss_count = (dataset_size / batch_size) + 1 # wandb includes it in the file one extra time
272+
expected_number_train_loss_count = (dataset_size / batch_size) * 2 # wandb includes it twice per step
273273
expected_number_train_metrics_count = (
274274
dataset_size / batch_size
275-
) + 2 # wandb includes it in the file two extra times
275+
) * 2 + 2 # wandb includes it twice per step plus two extra times
276276
expected_number_eval_metrics_count = 2 # wandb includes it in the file twice
277277
assert train_metrics_accuracy_count == expected_number_train_metrics_count
278278
assert train_loss_count == expected_number_train_loss_count

0 commit comments

Comments
 (0)