Skip to content

Commit 0e0e8bc

Browse files
jaredmixpaneltdumitrescu
authored andcommitted
dont provide default time prop
1 parent 8eded5f commit 0e0e8bc

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

lib/mixpanel-node.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,10 @@ var create_client = function(token, config) {
234234
if (batch.length > 0) {
235235
batch = batch.map(function (event) {
236236
var properties = event.properties;
237-
238-
event.properties.time = ensure_timestamp(event.properties.time || Date.now());
237+
if (endpoint === '/import' || event.properties.time) {
238+
// usually there will be a time property, but not required for `/track` endpoint
239+
event.properties.time = ensure_timestamp(event.properties.time);
240+
}
239241
event.properties.token = event.properties.token || metrics.token;
240242
return event;
241243
});
@@ -291,7 +293,10 @@ var create_client = function(token, config) {
291293
properties = {};
292294
}
293295

294-
properties.time = ensure_timestamp(properties.time || Date.now());
296+
// time is optional for `track`
297+
if (properties.time) {
298+
properties.time = ensure_timestamp(properties.time);
299+
}
295300

296301
metrics.send_event_request("/track", event, properties, callback);
297302
};

lib/profile_helpers.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ function merge_modifiers(data, modifiers) {
1818
}
1919
if (modifiers.hasOwnProperty("$time")) {
2020
data.$time = ensure_timestamp(modifiers.$time);
21-
} else {
22-
data.$time = Date.now();
2321
}
2422
if (modifiers.hasOwnProperty("$latitude") && modifiers.hasOwnProperty('$longitude')) {
2523
data.$latitude = modifiers.$latitude;

test/import.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ exports.import = {
8282
properties: {
8383
key1: 'val1',
8484
token: 'token',
85-
time: Math.floor(mock_now_time)
85+
time: mock_now_time
8686
}
8787
};
8888

0 commit comments

Comments
 (0)