Skip to content

Commit 69c3d16

Browse files
committed
refactor: MocketSSLSocket use proper ssl-context instead of urllib3
1 parent e778928 commit 69c3d16

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

mocket/ssl/socket.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,23 @@ def unwrap(self) -> MocketSocket:
6262
return self._original_socket
6363

6464
@classmethod
65-
def _create(cls, sock: MocketSocket, *args: Any, **kwargs: Any) -> MocketSSLSocket:
65+
def _create(
66+
cls,
67+
sock: MocketSocket,
68+
ssl_context: ssl.SSLContext | None = None,
69+
server_hostname: str | None = None,
70+
*args: Any,
71+
**kwargs: Any,
72+
) -> MocketSSLSocket:
6673
ssl_socket = MocketSSLSocket()
6774
ssl_socket._original_socket = sock
75+
ssl_socket._true_socket = sock._true_socket
6876

69-
from mocket.urllib3 import true_ssl_wrap_socket
70-
71-
ssl_socket._true_socket = true_ssl_wrap_socket(
72-
sock._true_socket,
73-
**kwargs,
74-
)
77+
if ssl_context:
78+
ssl_socket._true_socket = ssl_context.wrap_socket(
79+
sock=ssl_socket._true_socket,
80+
server_hostname=server_hostname,
81+
)
7582

7683
ssl_socket._kwargs = kwargs
7784

mocket/urllib3.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,10 @@
22

33
from typing import Any
44

5-
import urllib3
65
from mocket.socket import MocketSocket
76
from mocket.ssl.context import MocketSSLContext
87
from mocket.ssl.socket import MocketSSLSocket
98

10-
true_ssl_wrap_socket = urllib3.util.ssl_.ssl_wrap_socket
11-
129

1310
def mock_match_hostname(*args: Any) -> None:
1411
return None

0 commit comments

Comments
 (0)