Skip to content

Commit 885a7ac

Browse files
authored
Fix warning - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (#22800)
### Description This PR Fix warning - `LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format` from all Dockerfile ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
1 parent 1f3b675 commit 885a7ac

22 files changed

+37
-37
lines changed

dockerfiles/Dockerfile.migraphx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ FROM rocm/pytorch:rocm6.2.3_ubuntu22.04_py3.10_pytorch_release_2.3.0
1010
ARG ONNXRUNTIME_REPO=https://github.com/Microsoft/onnxruntime
1111
ARG ONNXRUNTIME_BRANCH=main
1212

13-
ENV PATH /code/cmake-3.27.3-linux-x86_64/bin:${PATH}
13+
ENV PATH=/code/cmake-3.27.3-linux-x86_64/bin:${PATH}
1414

1515
RUN apt-get update &&\
1616
apt-get install -y migraphx

dockerfiles/Dockerfile.openvino

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ FROM openvino/ubuntu22_runtime:${OPENVINO_VERSION} AS builder
1111

1212
ENV WORKDIR_PATH=/home/openvino
1313
WORKDIR $WORKDIR_PATH
14-
ENV DEBIAN_FRONTEND noninteractive
14+
ENV DEBIAN_FRONTEND=noninteractive
1515

1616
ARG DEVICE=CPU
1717
ARG ONNXRUNTIME_REPO=https://github.com/microsoft/onnxruntime.git
@@ -41,7 +41,7 @@ RUN tar cvf GPL_sources.tar.gz /sources
4141
# Deploy stage
4242
FROM openvino/ubuntu22_runtime:${OPENVINO_VERSION}
4343

44-
ENV DEBIAN_FRONTEND noninteractive
44+
ENV DEBIAN_FRONTEND=noninteractive
4545
USER root
4646
COPY --from=builder /home/openvino/onnxruntime/build/Linux/Release/dist/*.whl ./
4747
COPY --from=builder /GPL_sources.tar.gz ./
@@ -50,7 +50,7 @@ ARG BUILD_UID=1001
5050
ARG BUILD_USER=onnxruntimedev
5151
RUN adduser --uid $BUILD_UID $BUILD_USER
5252
RUN usermod -a -G video,users ${BUILD_USER}
53-
ENV WORKDIR_PATH /home/${BUILD_USER}
53+
ENV WORKDIR_PATH=/home/${BUILD_USER}
5454
WORKDIR ${WORKDIR_PATH}
5555

5656
USER ${BUILD_USER}

dockerfiles/Dockerfile.rocm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ ARG ONNXRUNTIME_BRANCH=main
1212

1313
WORKDIR /code
1414

15-
ENV PATH /code/cmake-3.27.3-linux-x86_64/bin:${PATH}
15+
ENV PATH=/code/cmake-3.27.3-linux-x86_64/bin:${PATH}
1616

1717
# Prepare onnxruntime repository & build onnxruntime
1818
RUN git clone --single-branch --branch ${ONNXRUNTIME_BRANCH} --recursive ${ONNXRUNTIME_REPO} onnxruntime &&\

dockerfiles/Dockerfile.tensorrt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ RUN apt-get update &&\
1717
RUN unattended-upgrade
1818

1919
WORKDIR /code
20-
ENV PATH /usr/local/nvidia/bin:/usr/local/cuda/bin:/code/cmake-3.27.3-linux-x86_64/bin:/opt/miniconda/bin:${PATH}
20+
ENV PATH=/usr/local/nvidia/bin:/usr/local/cuda/bin:/code/cmake-3.27.3-linux-x86_64/bin:/opt/miniconda/bin:${PATH}
2121

2222
# Prepare onnxruntime repository & build onnxruntime with TensorRT
2323
RUN git clone --single-branch --branch ${ONNXRUNTIME_BRANCH} --recursive ${ONNXRUNTIME_REPO} onnxruntime &&\

dockerfiles/Dockerfile.vitisai

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ RUN apt-get update && \
2222
apt-get clean && \
2323
rm -rf /var/lib/apt/lists/*
2424

25-
ENV PATH /code/cmake-3.27.3-linux-x86_64/bin:$PATH
26-
ENV LD_LIBRARY_PATH /opt/xilinx/xrt/lib:$LD_LIBRARY_PATH
25+
ENV PATH=/code/cmake-3.27.3-linux-x86_64/bin:$PATH
26+
ENV LD_LIBRARY_PATH=/opt/xilinx/xrt/lib:$LD_LIBRARY_PATH
2727

2828
WORKDIR /code
2929
RUN . $VAI_ROOT/conda/etc/profile.d/conda.sh &&\

orttraining/tools/amdgpu/Dockerfile.rocm4.3.1.pytorch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ RUN cd MLNX_OFED_LINUX-${MOFED_VERSION}-${MOFED_OS}-x86_64 && \
4646
rm -r MLNX_OFED_LINUX-${MOFED_VERSION}-${MOFED_OS}-x86_64
4747

4848
ENV PATH=${OLD_PATH}
49-
ENV unset OLD_PATH
49+
ENV unset=OLD_PATH
5050

5151
# python env
5252
RUN pip3 install --upgrade setuptools

tools/ci_build/github/linux/docker/Dockerfile.manylinux2_28_cuda

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,5 @@ ARG BUILD_USER=onnxruntimedev
4242
RUN adduser --uid $BUILD_UID $BUILD_USER
4343
WORKDIR /home/$BUILD_USER
4444
USER $BUILD_USER
45-
ENV PATH /usr/local/dotnet:$PATH
46-
ENV CUDA_MODULE_LOADING "LAZY"
45+
ENV PATH=/usr/local/dotnet:$PATH
46+
ENV CUDA_MODULE_LOADING="LAZY"

tools/ci_build/github/linux/docker/Dockerfile.manylinux2_28_rocm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,5 +201,5 @@ ARG BUILD_USER=onnxruntimedev
201201
RUN adduser --uid $BUILD_UID $BUILD_USER
202202
WORKDIR /home/$BUILD_USER
203203
USER $BUILD_USER
204-
ENV PATH /usr/local/dotnet:$PATH
204+
ENV PATH=/usr/local/dotnet:$PATH
205205
ENV ORTMODULE_ONNX_OPSET_VERSION=$OPSET_VERSION

tools/ci_build/github/linux/docker/Dockerfile.package_ubi8_cuda11_8_tensorrt8_6

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ ARG BASEIMAGE=nvidia/cuda:11.8.0-cudnn8-devel-ubi8
99
ARG TRT_VERSION=8.6.1.6-1.cuda11.8
1010
FROM $BASEIMAGE AS base
1111
ARG TRT_VERSION
12-
ENV PATH /usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/src/tensorrt/bin:${PATH}
12+
ENV PATH=/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/src/tensorrt/bin:${PATH}
1313

1414
RUN dnf install -y bash wget &&\
1515
dnf clean dbcache

tools/ci_build/github/linux/docker/Dockerfile.package_ubi8_cuda_tensorrt10_0

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ ARG BASEIMAGE=nvidia/cuda:12.5.1-cudnn-devel-ubi8
99
ARG TRT_VERSION=10.6.0.26-1.cuda12.6
1010
FROM $BASEIMAGE AS base
1111
ARG TRT_VERSION
12-
ENV PATH /opt/python/cp310-cp310/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/src/tensorrt/bin:${PATH}
12+
ENV PATH=/opt/python/cp310-cp310/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/src/tensorrt/bin:${PATH}
1313

1414
RUN dnf install -y bash wget &&\
1515
dnf clean dbcache

0 commit comments

Comments
 (0)