Fix incorrectly wrapped strings by localization routines (#414)

This commit fixes #413. Additionally, nonf variants of functions in output pkg
have been added so that string returned by localization routine is printed as
is and no further format specifier substitution can take place.

Author: apoorvdeshmukh

cmd/modern/root/config/add-context.go

@@ -69,7 +69,7 @@ func (c *AddContext) run() {
 	}
 
 	if c.endpointName == "" || !config.EndpointExists(c.endpointName) {
-		output.FatalfWithHintExamples([][]string{
+		output.FatalWithHintExamples([][]string{
 			{localizer.Sprintf("View existing endpoints to choose from"), "sqlcmd config get-endpoints"},
 			{localizer.Sprintf("Add a new local endpoint"), "sqlcmd create"},
 			{localizer.Sprintf("Add an already existing endpoint"), "sqlcmd config add-endpoint --address localhost --port 1433"}},
@@ -78,7 +78,7 @@ func (c *AddContext) run() {
 
 	if c.userName != "" {
 		if !config.UserNameExists(c.userName) {
-			output.FatalfWithHintExamples([][]string{
+			output.FatalWithHintExamples([][]string{
 				{localizer.Sprintf("View list of users"), "sqlcmd config get-users"},
 				{localizer.Sprintf("Add the user"), fmt.Sprintf("sqlcmd config add-user --name %v", c.userName)},
 				{localizer.Sprintf("Add an endpoint"), "sqlcmd create"}},
@@ -88,7 +88,7 @@ func (c *AddContext) run() {
 
 	context.Name = config.AddContext(context)
 	config.SetCurrentContextName(context.Name)
-	output.InfofWithHintExamples([][]string{
+	output.InfoWithHintExamples([][]string{
 		{localizer.Sprintf("Open in Azure Data Studio"), "sqlcmd open ads"},
 		{localizer.Sprintf("To start interactive query session"), "sqlcmd query"},
 		{localizer.Sprintf("To run a query"), "sqlcmd query \"SELECT @@version\""},

cmd/modern/root/config/add-endpoint.go

@@ -74,7 +74,7 @@ func (c *AddEndpoint) run() {
 	}
 
 	uniqueEndpointName := config.AddEndpoint(endpoint)
-	output.InfofWithHintExamples([][]string{
+	output.InfoWithHintExamples([][]string{
 		{localizer.Sprintf("Add a context for this endpoint"), fmt.Sprintf("sqlcmd config add-context --endpoint %v", uniqueEndpointName)},
 		{localizer.Sprintf("View endpoint names"), "sqlcmd config get-endpoints"},
 		{localizer.Sprintf("View endpoint details"), fmt.Sprintf("sqlcmd config get-endpoints %v", uniqueEndpointName)},

cmd/modern/root/config/add-user.go

@@ -106,7 +106,7 @@ func (c *AddUser) run() {
 
 	if c.authType != "basic" &&
 		c.authType != "other" {
-		output.FatalfWithHints([]string{localizer.Sprintf("Authentication type must be '%s' or '%s'", localizer.ModernAuthTypeBasic, localizer.ModernAuthTypeOther)},
+		output.FatalWithHints([]string{localizer.Sprintf("Authentication type must be '%s' or '%s'", localizer.ModernAuthTypeBasic, localizer.ModernAuthTypeOther)},
 			localizer.Sprintf("Authentication type '' is not valid %v'", c.authType))
 	}
 
@@ -136,15 +136,15 @@ func (c *AddUser) run() {
 		}
 
 		if c.username == "" {
-			output.FatalfWithHintExamples([][]string{
+			output.FatalWithHintExamples([][]string{
 				{localizer.Sprintf("Provide a username with the %s flag"),
 					"sqlcmd config add-user --username sa"},
 			},
 				localizer.Sprintf("Username not provided"))
 		}
 
 		if !secret.IsValidEncryptionMethod(c.passwordEncryption) {
-			output.FatalfWithHints([]string{
+			output.FatalWithHints([]string{
 				localizer.Sprintf("Provide a valid encryption method (%s) with the %s flag", secret.EncryptionMethodsForUsage(), localizer.PasswordEncryptFlag)},
 				localizer.Sprintf("Encryption method '%v' is not valid", c.passwordEncryption))
 		}
@@ -168,5 +168,5 @@ func (c *AddUser) run() {
 	}
 
 	uniqueUserName := config.AddUser(user)
-	output.Infof(localizer.Sprintf("User '%v' added", uniqueUserName))
+	output.Info(localizer.Sprintf("User '%v' added", uniqueUserName))
 }

cmd/modern/root/config/connection-strings.go

@@ -120,7 +120,7 @@ func (c *ConnectionStrings) run() {
 			output.Infof("%-8s %s", k+":", v)
 		}
 	} else {
-		output.Infof(localizer.Sprintf("Connection Strings only supported for %s Auth type", localizer.ModernAuthTypeBasic))
+		output.Info(localizer.Sprintf("Connection Strings only supported for %s Auth type", localizer.ModernAuthTypeBasic))
 	}
 }
 

cmd/modern/root/config/delete-context.go

@@ -78,9 +78,9 @@ func (c *DeleteContext) run() {
 
 		config.DeleteContext(c.name)
 
-		output.Infof(localizer.Sprintf("Context '%v' deleted", c.name))
+		output.Info(localizer.Sprintf("Context '%v' deleted", c.name))
 	} else {
-		output.FatalfWithHintExamples([][]string{
+		output.FatalWithHintExamples([][]string{
 			{localizer.Sprintf("View available contexts"), "sqlcmd config get-contexts"},
 		},
 			localizer.Sprintf("Context '%v' does not exist", c.name))

cmd/modern/root/config/delete-endpoint.go

@@ -54,11 +54,11 @@ func (c *DeleteEndpoint) run() {
 	if config.EndpointExists(c.name) {
 		config.DeleteEndpoint(c.name)
 	} else {
-		output.FatalfWithHintExamples([][]string{
+		output.FatalWithHintExamples([][]string{
 			{localizer.Sprintf("View endpoints"), "sqlcmd config get-endpoints"},
 		},
 			localizer.Sprintf("Endpoint '%v' does not exist", c.name))
 	}
 
-	output.Infof(localizer.Sprintf("Endpoint '%v' deleted", c.name))
+	output.Info(localizer.Sprintf("Endpoint '%v' deleted", c.name))
 }

cmd/modern/root/config/delete-user.go

@@ -51,11 +51,11 @@ func (c *DeleteUser) run() {
 	if config.UserNameExists(c.name) {
 		config.DeleteUser(c.name)
 	} else {
-		output.FatalfWithHintExamples([][]string{
+		output.FatalWithHintExamples([][]string{
 			{localizer.Sprintf("View users"), "sqlcmd config get-users"},
 		},
 			localizer.Sprintf("User %q does not exist", c.name))
 	}
 
-	output.Infof(localizer.Sprintf("User %q deleted", c.name))
+	output.Info(localizer.Sprintf("User %q deleted", c.name))
 }

cmd/modern/root/config/get-contexts.go

@@ -61,7 +61,7 @@ func (c *GetContexts) run() {
 			context := config.GetContext(c.name)
 			output.Struct(context)
 		} else {
-			output.FatalfWithHints(
+			output.FatalWithHints(
 				[]string{localizer.Sprintf("To view available contexts run `%s`", localizer.GetContextCommand)},
 				localizer.Sprintf("error: no context exists with the name: \"%v\"", c.name))
 		}

cmd/modern/root/config/get-endpoints.go

@@ -57,7 +57,7 @@ func (c *GetEndpoints) run() {
 			context := config.GetEndpoint(c.name)
 			output.Struct(context)
 		} else {
-			output.FatalfWithHints(
+			output.FatalWithHints(
 				[]string{localizer.Sprintf("To view available endpoints run `%s`", localizer.GetEndpointsCommand)},
 				localizer.Sprintf("error: no endpoint exists with the name: \"%v\"", c.name))
 		}

cmd/modern/root/config/get-users.go

@@ -61,7 +61,7 @@ func (c *GetUsers) run() {
 			user := config.GetUser(c.name)
 			output.Struct(user)
 		} else {
-			output.FatalfWithHints(
+			output.FatalWithHints(
 				[]string{localizer.Sprintf("To view available users run `%s`", localizer.GetUsersCommand)},
 				localizer.Sprintf("error: no user exists with the name: \"%v\"", c.name))
 		}