Skip to content

Commit ddd5586

Browse files
committed
Run pylint and black
1 parent c841c35 commit ddd5586

File tree

7 files changed

+36
-34
lines changed

7 files changed

+36
-34
lines changed

examples/basic_bitbang.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,28 +17,28 @@
1717
sr = SR74HC595_BITBANG(ser, srclk, rclk)
1818

1919
sr.clear() # raises RuntimeError because you haven't provide srclr pin
20-
sr.enable() # raises RuntimeError because you haven't provide oe pin
20+
sr.enable() # raises RuntimeError because you haven't provide oe pin
2121

2222
# reconstruct with all pins
23-
oe = Pin(33, Pin.OUT, value=0) # low enables output
24-
srclr = Pin(32, Pin.OUT, value=1) # pulsing low clears data
23+
oe = Pin(33, Pin.OUT, value=0) # low enables output
24+
srclr = Pin(32, Pin.OUT, value=1) # pulsing low clears data
2525

2626
sr = SR74HC595_BITBANG(ser, srclk, rclk, srclr, oe)
2727

2828
sr.bit(1) # send high bit, do not latch yet
2929
sr.bit(0) # send low bit, do not latch yet
30-
sr.latch() # latch outputs, outputs=0000_0010
30+
sr.latch() # latch outputs, outputs=0000_0010
3131

32-
sr.bit(1, 1) # send high bit and latch, outputs=0000_0101
33-
sr.bit(0, 1) # send low bit and latch, outputs=0000_1010
32+
sr.bit(1, 1) # send high bit and latch, outputs=0000_0101
33+
sr.bit(0, 1) # send low bit and latch, outputs=0000_1010
3434

35-
sr.bits(0xff, 4) # send 4 lowest bits of 0xff (sends 0x0f), outputs=1010_1111
35+
sr.bits(0xFF, 4) # send 4 lowest bits of 0xff (sends 0x0f), outputs=1010_1111
3636

37-
sr.clear(0) # clear the memory but don't latch yet
37+
sr.clear(0) # clear the memory but don't latch yet
3838
sr.latch() # next latch shows the outputs have been reset
3939

40-
sr.bits(0b1010_1010, 8) # write some bits
40+
sr.bits(0b1010_1010, 8) # write some bits
4141
sr.clear() # clear the memory and latch, outputs have been reset
4242

4343
sr.enable() # outputs enabled
44-
sr.enable(0) # outputs disabled
44+
sr.enable(0) # outputs disabled

examples/basic_spi.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,20 @@
1212
spi = SPI(1, 100000)
1313
rclk = Pin(5, Pin.OUT)
1414

15-
oe = Pin(33, Pin.OUT, value=0) # low enables output
16-
srclr = Pin(32, Pin.OUT, value=1) # pulsing low clears data
15+
oe = Pin(33, Pin.OUT, value=0) # low enables output
16+
srclr = Pin(32, Pin.OUT, value=1) # pulsing low clears data
1717

18-
sr = SR74HC595_SPI(spi, rclk, 2) # chain of 2 shift registers
18+
sr = SR74HC595_SPI(spi, rclk, 2) # chain of 2 shift registers
1919

20-
sr.pin(2,1) # set pin 2 high of furthest shift register
21-
sr.pin(2) # read pin 2
22-
sr.pin(2,0) # set pin 2 low
20+
sr.pin(2, 1) # set pin 2 high of furthest shift register
21+
sr.pin(2) # read pin 2
22+
sr.pin(2, 0) # set pin 2 low
2323

24-
sr.toggle(8) # toggle first pin of closest shift register
24+
sr.toggle(8) # toggle first pin of closest shift register
2525

26-
sr[0] = 0xff # set all pins high on furthest shift register
26+
sr[0] = 0xFF # set all pins high on furthest shift register
2727
sr[1] = 240 # set half pins high on closest shift register
28-
sr[1] # read pins
28+
print(sr[1]) # read pins
2929

3030
oe.value(0) # disable outputs
3131
oe.value(1) # enable outputs

examples/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
["sr74hc595/examples/basic_spi.py", "github:mcauser/micropython-74hc595/examples/basic_spi.py"]
55
],
66
"deps": [],
7-
"version": "1.0.0"
7+
"version": "1.0.1"
88
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
["sr74hc595/sr74hc595_spi.py", "github:mcauser/micropython-74hc595/src/sr74hc595_spi.py"]
66
],
77
"deps": [],
8-
"version": "1.0.0"
8+
"version": "1.0.1"
99
}

readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ If you don't need to clear the outputs, connect `srclr` to vcc.
8080
If you don't need to disable the outputs, connect `oe` to gnd.
8181

8282
```python
83-
__init__(spi, rclk, len=1, srclr=None, oe=None)
83+
__init__(spi, rclk, length=1, srclr=None, oe=None)
8484
```
8585

8686
Read the boolean value of a pin. First pin is index `0`. If you are cascading shift

src/sr74hc595_bitbang.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,16 @@
66
https://github.com/mcauser/micropython-74hc595
77
"""
88

9-
__version__ = '1.0.0'
9+
__version__ = "1.0.1"
10+
1011

1112
class SR74HC595_BITBANG:
1213
def __init__(self, ser, srclk, rclk, srclr=None, oe=None):
1314
self.ser = ser
1415
self.srclk = srclk
1516
self.rclk = rclk
1617
self.srclr = srclr # tie high if functionality not needed
17-
self.oe = oe # tie low if functionality not needed
18+
self.oe = oe # tie low if functionality not needed
1819

1920
self.ser.init(ser.OUT, value=0)
2021
self.srclk.init(srclk.OUT, value=0)
@@ -47,13 +48,13 @@ def latch(self):
4748

4849
def clear(self, latch=True):
4950
if self.srclr is None:
50-
raise RuntimeError('srclr pin is required')
51+
raise RuntimeError("srclr pin is required")
5152
self.srclr(0)
5253
self.srclr(1)
5354
if latch:
5455
self.latch()
5556

5657
def enable(self, enabled=True):
5758
if self.oe is None:
58-
raise RuntimeError('oe pin is required')
59+
raise RuntimeError("oe pin is required")
5960
self.oe(not enabled)

src/sr74hc595_spi.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,17 @@
66
https://github.com/mcauser/micropython-74hc595
77
"""
88

9-
__version__ = '1.0.0'
9+
__version__ = "1.0.1"
10+
1011

1112
class SR74HC595_SPI:
12-
def __init__(self, spi, rclk, len=1, srclr=None, oe=None):
13+
def __init__(self, spi, rclk, length=1, srclr=None, oe=None):
1314
self.spi = spi
1415
self.rclk = rclk
1516
self.srclr = srclr # tie high if functionality not needed
16-
self.oe = oe # tie low if functionality not needed
17+
self.oe = oe # tie low if functionality not needed
1718

18-
self.buf = bytearray(len)
19+
self.buf = bytearray(length)
1920
self.rclk.init(rclk.OUT, value=0)
2021

2122
if self.srclr is not None:
@@ -36,26 +37,26 @@ def pin(self, pin, value=None, latch=True):
3637
if value is None:
3738
return (self.buf[pin // 8] >> (pin % 8)) & 1
3839
elif value:
39-
self.buf[pin // 8] |= (1 << (pin % 8))
40+
self.buf[pin // 8] |= 1 << (pin % 8)
4041
else:
4142
self.buf[pin // 8] &= ~(1 << (pin % 8))
4243
self._write(latch)
4344

4445
def toggle(self, pin, latch=True):
45-
self.buf[pin // 8] ^= (1 << (pin % 8))
46+
self.buf[pin // 8] ^= 1 << (pin % 8)
4647
self._write(latch)
4748

4849
def clear(self, latch=True):
4950
if self.srclr is None:
50-
raise RuntimeError('srclr pin is required')
51+
raise RuntimeError("srclr pin is required")
5152
self.srclr(0)
5253
self.srclr(1)
5354
if latch:
5455
self.latch()
5556

5657
def enable(self, enabled=True):
5758
if self.oe is None:
58-
raise RuntimeError('oe pin is required')
59+
raise RuntimeError("oe pin is required")
5960
self.oe(not enabled)
6061

6162
def __getitem__(self, index):

0 commit comments

Comments
 (0)