Skip to content

Commit cb77951

Browse files
arjxn-pymfisher87
authored andcommitted
Fix Overlapping of Panels on smaller screens (geojupyter#896)
* add a mediquery to panels for mobiles * wrap panels to a container and give it style * lint
1 parent 7edfe03 commit cb77951

File tree

2 files changed

+36
-14
lines changed

2 files changed

+36
-14
lines changed

packages/base/src/mainview/mainView.tsx

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2299,20 +2299,22 @@ export class MainView extends React.Component<IProps, IStates> {
22992299
/>
23002300
</div>
23012301

2302-
{this._state && (
2303-
<LeftPanel
2304-
model={this._model}
2305-
commands={this._mainViewModel.commands}
2306-
state={this._state}
2307-
></LeftPanel>
2308-
)}
2309-
{this._formSchemaRegistry && this._annotationModel && (
2310-
<RightPanel
2311-
model={this._model}
2312-
formSchemaRegistry={this._formSchemaRegistry}
2313-
annotationModel={this._annotationModel}
2314-
></RightPanel>
2315-
)}
2302+
<div className="jgis-panels-wrapper">
2303+
{this._state && (
2304+
<LeftPanel
2305+
model={this._model}
2306+
commands={this._mainViewModel.commands}
2307+
state={this._state}
2308+
></LeftPanel>
2309+
)}
2310+
{this._formSchemaRegistry && this._annotationModel && (
2311+
<RightPanel
2312+
model={this._model}
2313+
formSchemaRegistry={this._formSchemaRegistry}
2314+
annotationModel={this._annotationModel}
2315+
></RightPanel>
2316+
)}
2317+
</div>
23162318
</>
23172319
);
23182320
}

packages/base/style/base.css

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,3 +101,23 @@ button.jp-mod-styled.jp-mod-reject {
101101
left: 0px;
102102
margin: 5px;
103103
}
104+
105+
@media (max-width: 768px) {
106+
.jgis-panels-wrapper {
107+
position: fixed;
108+
top: 30px;
109+
display: flex;
110+
flex-direction: column;
111+
align-items: flex-start;
112+
gap: 10px;
113+
margin: 0 5px;
114+
z-index: 1000;
115+
width: 60%;
116+
}
117+
118+
.jgis-left-panel-container,
119+
.jgis-right-panel-container {
120+
position: relative;
121+
margin: 0;
122+
}
123+
}

0 commit comments

Comments
 (0)