Skip to content

Commit a503a8e

Browse files
ThamsterYour Name
authored andcommitted
android : fix build and ci (ggml-org#2624)
* Adding missing CMakeLists.txt include for ggm-cpu needed by whisper.android * attempt to re-enable CI for JNI android --------- Co-authored-by: Your Name <[email protected]>
1 parent ba757e3 commit a503a8e

File tree

2 files changed

+30
-29
lines changed

2 files changed

+30
-29
lines changed

.github/workflows/build.yml

Lines changed: 28 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -564,35 +564,34 @@ jobs:
564564
- name: Build swiftui example
565565
run: xcodebuild -project examples/whisper.swiftui/whisper.swiftui.xcodeproj -scheme WhisperCppDemo -configuration ${{ matrix.build }} -sdk iphoneos CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= -destination 'generic/platform=iOS' build
566566

567-
# TODO: update android build and re-enable when it works
568-
# android:
569-
# runs-on: ubuntu-latest
570-
#
571-
# steps:
572-
# - name: Clone
573-
# uses: actions/checkout@v4
574-
# with:
575-
# path: whisper
576-
#
577-
# - name: Install Java
578-
# uses: actions/setup-java@v4
579-
# with:
580-
# distribution: zulu
581-
# java-version: 21
582-
#
583-
# - name: Setup Android SDK
584-
# uses: android-actions/setup-android@v3
585-
#
586-
# - name: Build
587-
# run: |
588-
# cd whisper/examples/whisper.android
589-
# ./gradlew assembleRelease --no-daemon
590-
#
591-
# - name: Build with external ggml
592-
# run: |
593-
# export PATH_TO_GGML=$PWD/ggml
594-
# cd whisper/examples/whisper.android
595-
# ./gradlew assembleRelease --no-daemon
567+
android:
568+
runs-on: ubuntu-latest
569+
570+
steps:
571+
- name: Clone
572+
uses: actions/checkout@v4
573+
with:
574+
path: whisper
575+
576+
- name: Install Java
577+
uses: actions/setup-java@v4
578+
with:
579+
distribution: zulu
580+
java-version: 21
581+
582+
- name: Setup Android SDK
583+
uses: android-actions/setup-android@v3
584+
585+
- name: Build
586+
run: |
587+
cd whisper/examples/whisper.android
588+
./gradlew assembleRelease --no-daemon
589+
590+
- name: Build with external ggml
591+
run: |
592+
export PATH_TO_GGML=$PWD/ggml
593+
cd whisper/examples/whisper.android
594+
./gradlew assembleRelease --no-daemon
596595
597596
# TODO: disable because of following fail: https://github.com/ggerganov/whisper.cpp/actions/runs/11019444420/job/30627193602
598597
# android_java:

examples/whisper.android/lib/src/main/jni/whisper/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,5 @@ include_directories(${WHISPER_LIB_DIR}/src)
8888
include_directories(${WHISPER_LIB_DIR}/include)
8989
include_directories(${WHISPER_LIB_DIR}/ggml/include)
9090
include_directories(${WHISPER_LIB_DIR}/ggml/src)
91+
include_directories(${WHISPER_LIB_DIR}/ggml/src/ggml-cpu)
92+

0 commit comments

Comments
 (0)