Skip to content

Commit 666d802

Browse files
Tvrtko Ursulinlutzbichler
authored andcommitted
drm/sched: Remove weak paused submission checks
There is no need to check the boolean in the work item's prologues since the boolean can be set at any later time anyway. The helper which pauses submission sets it and synchronously cancels the work and helpers which queue the work check for the flag so all should be good. Signed-off-by: Tvrtko Ursulin <[email protected]> Cc: Christian König <[email protected]> Cc: Danilo Krummrich <[email protected]> Cc: Matthew Brost <[email protected]> Cc: Philipp Stanner <[email protected]> Signed-off-by: Philipp Stanner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 2078f28 commit 666d802

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/gpu/drm/scheduler/sched_main.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,9 +1153,6 @@ static void drm_sched_free_job_work(struct work_struct *w)
11531153
container_of(w, struct drm_gpu_scheduler, work_free_job);
11541154
struct drm_sched_job *job;
11551155

1156-
if (READ_ONCE(sched->pause_submit))
1157-
return;
1158-
11591156
job = drm_sched_get_finished_job(sched);
11601157
if (job)
11611158
sched->ops->free_job(job);
@@ -1179,9 +1176,6 @@ static void drm_sched_run_job_work(struct work_struct *w)
11791176
struct drm_sched_job *sched_job;
11801177
int r;
11811178

1182-
if (READ_ONCE(sched->pause_submit))
1183-
return;
1184-
11851179
/* Find entity with a ready job */
11861180
entity = drm_sched_select_entity(sched);
11871181
if (!entity)

0 commit comments

Comments
 (0)