Skip to content

Commit d1abdab

Browse files
matthew-deanmatthew-dean
authored
✨ feat: deprecation warnings for Less + monorepo chores (#4319)
* Added deprecation warnings * Remove warning about combinator * Switch to PNPM * Update local dependencies * Remove inner dist folder * Create symbolic link to dist folder * Flip dist folders * Create symbolic link in root * Add contributors * 👥 Add @matthew-dean as a contributor * 👥 Add @cloudhead as a contributor * 👥 Add @lukeapage as a contributor * 👥 Add @seven-phases-max as a contributor * 👥 Add @iChenLei as a contributor * 👥 Add @puckowski as a contributor * Add more contributors * Finish deprecation warnings * Resolve deletions and such * Fix symbolic link * Update ci.yml to use PNPM * Update ci.yml to use PNPM * Refine CI versions * Fix node printed version * Better fix for #4258 and #4292 * Re-enable other tests
1 parent 1e7b003 commit d1abdab

35 files changed

+9849
-45330
lines changed

‎.all-contributorsrc‎

Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
{
2+
"projectName": "Less.js",
3+
"projectOwner": "The Less CSS Team",
4+
"repoType": "github",
5+
"repoHost": "https://github.com/less/less.js",
6+
"files": [
7+
"README.md"
8+
],
9+
"imageSize": 100,
10+
"commit": true,
11+
"commitConvention": "gitmoji",
12+
"contributors": [
13+
{
14+
"login": "matthew-dean",
15+
"name": "Matthew Dean",
16+
"avatar_url": "https://avatars.githubusercontent.com/u/414752?v=4",
17+
"profile": "https://github.com/matthew-dean",
18+
"contributions": [
19+
"code",
20+
"doc",
21+
"maintenance",
22+
"projectManagement"
23+
]
24+
},
25+
{
26+
"login": "cloudhead",
27+
"name": "Alexis Sellier",
28+
"avatar_url": "https://avatars.githubusercontent.com/u/40774?v=4",
29+
"profile": "https://cloudhead.io/",
30+
"contributions": [
31+
"code",
32+
"doc"
33+
]
34+
},
35+
{
36+
"login": "lukeapage",
37+
"name": "Luke Page",
38+
"avatar_url": "https://avatars.githubusercontent.com/u/309321?v=4",
39+
"profile": "https://github.com/lukeapage",
40+
"contributions": [
41+
"code"
42+
]
43+
},
44+
{
45+
"login": "seven-phases-max",
46+
"name": "Max Mikhailov",
47+
"avatar_url": "https://avatars.githubusercontent.com/u/5304376?v=4",
48+
"profile": "https://github.com/seven-phases-max",
49+
"contributions": [
50+
"code"
51+
]
52+
},
53+
{
54+
"login": "iChenLei",
55+
"name": "Lei Chen",
56+
"avatar_url": "https://avatars.githubusercontent.com/u/14012511?v=4",
57+
"profile": "https://github.com/iChenLei",
58+
"contributions": [
59+
"code",
60+
"bug",
61+
"doc"
62+
]
63+
},
64+
{
65+
"login": "puckowski",
66+
"name": "Daniel Puckowski",
67+
"avatar_url": "https://avatars.githubusercontent.com/u/3059609?v=4",
68+
"profile": "https://github.com/puckowski",
69+
"contributions": [
70+
"code",
71+
"bug"
72+
]
73+
}
74+
],
75+
"contributorsPerLine": 7,
76+
"linkToUsage": true
77+
}

‎.github/workflows/ci.yml‎

Lines changed: 32 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -9,86 +9,40 @@ on:
99
branches: [main, master]
1010

1111
jobs:
12-
basic_node_test:
13-
name: 'Basic tests on ubuntu-latest with nodejs v22 (current LTS version)'
14-
runs-on: ubuntu-latest
15-
steps:
16-
- uses: actions/checkout@v2
17-
- uses: actions/setup-node@v2
18-
with:
19-
node-version: ${{ matrix.node }}
20-
- name: Install npm dependencies
21-
run: npm install
22-
- name: Print put node & npm version
23-
run: node --version && npm --version
24-
- name: Install chromium
25-
run: npx playwright install chromium
26-
- name: Run unit test
27-
run: npm run test
28-
29-
windows_and_macos_test:
30-
name: 'Platform tests on ${{matrix.os}} with nodejs v${{matrix.node}}'
31-
needs: basic_node_test
12+
test:
13+
name: 'Tests on ${{matrix.os}} with Node "${{matrix.node}}"'
3214
strategy:
3315
matrix:
34-
# Test all mainstream operating system
35-
os: [macos-latest, windows-latest]
36-
node: [22]
37-
runs-on: ${{ matrix.os }}
38-
steps:
39-
# Pull repo to test machine
40-
- uses: actions/checkout@v2
41-
# Configures the node version used on GitHub-hosted runners
42-
- uses: actions/setup-node@v2
43-
with:
44-
# The Node.js version to configure
45-
node-version: ${{ matrix.node }}
46-
- name: Install npm dependencies
47-
run: npm install
48-
- name: Print put node & npm version
49-
# Output useful info for debugging.
50-
run: node --version && npm --version
51-
- name: Install chromium
52-
run: npx playwright install chromium
53-
- name: Run unit test
54-
run: npm run test
16+
# Test all mainstream operating systems
17+
os: [ubuntu-latest, macos-latest, windows-latest]
18+
node: ['current']
19+
include:
20+
- os: ubuntu-latest
21+
node: 'lts/*'
22+
- os: ubuntu-latest
23+
node: 'lts/-1'
24+
- os: ubuntu-latest
25+
node: 'lts/-2'
26+
- os: ubuntu-latest
27+
node: 'lts/-3'
5528

56-
historical_versions_node_test:
57-
name: 'Historical version nodejs v${{matrix.node}} test'
58-
needs: basic_node_test
59-
strategy:
60-
matrix:
61-
os: [ubuntu-latest]
62-
node: [14, 16, 18, 20]
6329
runs-on: ${{ matrix.os }}
30+
# This has copy/paste steps and should be refactored using DRY
6431
steps:
65-
- uses: actions/checkout@v2
66-
- uses: actions/setup-node@v2
67-
with:
68-
node-version: ${{ matrix.node }}
69-
- name: Install npm dependencies
70-
run: npm install
71-
- name: Print put node & npm version
72-
run: node --version && npm --version
73-
- name: Install chromium
74-
run: npx playwright install chromium
75-
- name: Run unit test
76-
run: npm run test
77-
78-
latest_nodejs_testing_node23:
79-
name: 'Latest nodejs v23 test'
80-
needs: basic_node_test
81-
runs-on: ubuntu-latest
82-
steps:
83-
- uses: actions/checkout@v2
84-
- uses: actions/setup-node@v2
85-
with:
86-
node-version: 23
87-
- name: Install npm dependencies
88-
run: npm install
89-
- name: Print put node & npm version
90-
run: node --version && npm --version
91-
- name: Install chromium
92-
run: npx playwright install chromium
93-
- name: Run unit test
94-
run: npm run test
32+
- uses: actions/checkout@v4
33+
- name: Install pnpm
34+
uses: pnpm/action-setup@v4
35+
with:
36+
version: 8
37+
- uses: actions/setup-node@v4
38+
with:
39+
node-version: ${{ matrix.node }}
40+
cache: 'pnpm'
41+
- name: Install dependencies
42+
run: pnpm install
43+
- name: Print put node & npm version
44+
run: node --version && pnpm --version
45+
- name: Install chromium
46+
run: npx playwright install chromium
47+
- name: Run unit test
48+
run: pnpm run test

‎.nvmrc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v16

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Please report documentation issues in [the documentation project](https://github
2525

2626
* Please search for existing feature requests first to see if something similar already exists.
2727
* Include a clear and specific use-case. We love new ideas, but we do not add language features without a reason.
28-
* Consider whether or not your language feature would be better as a function or implemented in a 3rd-party build system such as [assemble-less](http://github.com/assemble/assemble-less).
28+
* Consider whether or not your language feature would be better as a function or implemented in a 3rd-party build system
2929

3030

3131
## Pull Requests
@@ -51,15 +51,4 @@ Learn more about [developing Less.js](http://lesscss.org/usage/#developing-less)
5151

5252
## Releases
5353

54-
Releases are managed using Lerna. First, we determine if the release is a major (breaking), minor (new features), or patch (bug fix) change.
55-
56-
Then, you can run Lerna with a command like:
57-
```
58-
npx lerna version minor
59-
```
60-
61-
To publish, run the Lerna command for publishing without incrementing the version, as in:
62-
```
63-
npx lerna publish from-package --no-private
64-
```
65-
54+
Releases are managed using PNPM. Instructions TBD

‎README.md‎

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
<p align="center"><img src="http://lesscss.org/public/img/less_logo.png" width="264" height="117">
2+
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
3+
[![All Contributors](https://img.shields.io/badge/all_contributors-6-orange.svg?style=flat-square)](#contributors-)
4+
<!-- ALL-CONTRIBUTORS-BADGE:END -->
25

36
<p align="center">
47
<a href="https://github.com/less/less.js/actions?query=branch%3Amaster"><img src="https://github.com/less/less.js/actions/workflows/ci.yml/badge.svg?branch=master" alt="Github Actions CI"/></a>
@@ -39,11 +42,39 @@ See the [changelog](CHANGELOG.md)
3942

4043
## Contributors
4144

42-
### Code Contributors
43-
4445
This project exists thanks to all the people who contribute. [[Contribute](CONTRIBUTING.md)].
4546
<a href="https://github.com/less/less.js/graphs/contributors"><img src="https://opencollective.com/less/contributors.svg?width=890&button=false" /></a>
4647

48+
<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
49+
<!-- prettier-ignore-start -->
50+
<!-- markdownlint-disable -->
51+
<table>
52+
<tbody>
53+
<tr>
54+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/matthew-dean"><img src="https://avatars.githubusercontent.com/u/414752?v=4?s=100" width="100px;" alt="Matthew Dean"/><br /><sub><b>Matthew Dean</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=matthew-dean" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/commits?author=matthew-dean" title="Documentation">📖</a> <a href="#maintenance-matthew-dean" title="Maintenance">🚧</a> <a href="#projectManagement-matthew-dean" title="Project Management">📆</a></td>
55+
<td align="center" valign="top" width="14.28%"><a href="https://cloudhead.io/"><img src="https://avatars.githubusercontent.com/u/40774?v=4?s=100" width="100px;" alt="Alexis Sellier"/><br /><sub><b>Alexis Sellier</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=cloudhead" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/commits?author=cloudhead" title="Documentation">📖</a></td>
56+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/lukeapage"><img src="https://avatars.githubusercontent.com/u/309321?v=4?s=100" width="100px;" alt="Luke Page"/><br /><sub><b>Luke Page</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=lukeapage" title="Code">💻</a></td>
57+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/seven-phases-max"><img src="https://avatars.githubusercontent.com/u/5304376?v=4?s=100" width="100px;" alt="Max Mikhailov"/><br /><sub><b>Max Mikhailov</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=seven-phases-max" title="Code">💻</a></td>
58+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/iChenLei"><img src="https://avatars.githubusercontent.com/u/14012511?v=4?s=100" width="100px;" alt="Lei Chen"/><br /><sub><b>Lei Chen</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=iChenLei" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/issues?q=author%3AiChenLei" title="Bug reports">🐛</a> <a href="https://github.com/The Less CSS Team/Less.js/commits?author=iChenLei" title="Documentation">📖</a></td>
59+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/puckowski"><img src="https://avatars.githubusercontent.com/u/3059609?v=4?s=100" width="100px;" alt="Daniel Puckowski"/><br /><sub><b>Daniel Puckowski</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=puckowski" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/issues?q=author%3Apuckowski" title="Bug reports">🐛</a></td>
60+
</tr>
61+
</tbody>
62+
<tfoot>
63+
<tr>
64+
<td align="center" size="13px" colspan="7">
65+
<img src="https://raw.githubusercontent.com/all-contributors/all-contributors-cli/1b8533af435da9854653492b1327a23a4dbd0a10/assets/logo-small.svg">
66+
<a href="https://all-contributors.js.org/docs/en/bot/usage">Add your contributions</a>
67+
</img>
68+
</td>
69+
</tr>
70+
</tfoot>
71+
</table>
72+
73+
<!-- markdownlint-restore -->
74+
<!-- prettier-ignore-end -->
75+
76+
<!-- ALL-CONTRIBUTORS-LIST:END -->
77+
4778

4879
## [License](LICENSE)
4980

0 commit comments

Comments
 (0)