From 1a1298bc72c5696e797082ddb639d0a77ebebb19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?= Date: Tue, 15 Apr 2025 12:09:55 +0200 Subject: [PATCH] Build: Make browser tests correctly run on multiple jQuery versions There was a typo in `jtr-local.yml`, making the runs using it load with a huge query string containing all the jQuery versions listed joined. Also, only IE and Safari runs even tried to use this config - the default run was not even reading the BROWSERS env variable. This all meant only one jQuery version was actually tested. Ref gh-576 --- .github/workflows/browser-tests.yml | 6 +++++- jtr-local.yml | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/browser-tests.yml b/.github/workflows/browser-tests.yml index 32aed686..4274dda9 100644 --- a/.github/workflows/browser-tests.yml +++ b/.github/workflows/browser-tests.yml @@ -43,7 +43,11 @@ jobs: run: npm install - name: Run tests - run: npm run test:browser -- -f plugin=${{ matrix.MIGRATE_VERSION }} + run: | + npm run pretest + npm run build:all + npm run test:unit -- -c jtr-local.yml \ + --headless -b ${{ matrix.BROWSER }} -f plugin=${{ matrix.MIGRATE_VERSION }} ie: runs-on: windows-latest diff --git a/jtr-local.yml b/jtr-local.yml index 9a7da180..e198c889 100644 --- a/jtr-local.yml +++ b/jtr-local.yml @@ -1,6 +1,6 @@ version: 1 -flags: +runs: jquery: - git - git.min